Enumerate missing resources when throwing MissingManifestResourceException (providing notice to developers of which resources are actually missing). (#4374)

Eric Dahlvang · JasonSowers · commit 7bc0b49aeb59 · 2018-04-13T14:15:51.000-07:00
diff --git a/CSharp/Library/Microsoft.Bot.Builder/FormFlow/FormBuilder.cs b/CSharp/Library/Microsoft.Bot.Builder/FormFlow/FormBuilder.cs
@@ -99,7 +99,7 @@ public virtual IForm<T> Build(Assembly resourceAssembly = null, string resourceN
                     _form.Localize(rs.GetEnumerator(), out missing, out extra);
                     if (missing.Any())
                     {
-                        throw new MissingManifestResourceException($"Missing resources {missing}");
+                        throw new MissingManifestResourceException($"Missing {missing.Count()} resources {string.Join(", ", missing)}");
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public virtual IForm<T> Build(Assembly resourceAssembly = null, string resourceN`
`99`	`99`	`_form.Localize(rs.GetEnumerator(), out missing, out extra);`
`100`	`100`	`if (missing.Any())`
`101`	`101`	`{`
`102`		`- throw new MissingManifestResourceException($"Missing resources {missing}");`
	`102`	`+ throw new MissingManifestResourceException($"Missing {missing.Count()} resources {string.Join(", ", missing)}");`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`	`}`