Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_header support #5249

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nour-bouzid
Copy link
Contributor

@nour-bouzid nour-bouzid commented Jan 29, 2025

Why are these changes needed?

Related issue number

Closes #5163

Checks

@nour-bouzid nour-bouzid force-pushed the feature/support_default_headers branch 2 times, most recently from 8188c25 to 82277c9 Compare January 29, 2025 13:40
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (6044924) to head (82277c9).
Report is 147 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5249      +/-   ##
==========================================
+ Coverage   68.61%   70.40%   +1.78%     
==========================================
  Files         156      179      +23     
  Lines       10053    11616    +1563     
==========================================
+ Hits         6898     8178    +1280     
- Misses       3155     3438     +283     
Flag Coverage Δ
unittests 70.40% <100.00%> (+1.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nour-bouzid nour-bouzid force-pushed the feature/support_default_headers branch from 82277c9 to 9937b10 Compare January 29, 2025 13:47
@ekzhu
Copy link
Collaborator

ekzhu commented Jan 29, 2025

Would be good if you can add deafult_headers to the argument list for both OpenAIChatCompletionClient and AzureOpenAIChatCompletionClient, the API doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChatCompletionClient.load_component support default-headers
2 participants