Replies: 1 comment
-
The thought was it was just easier to implement A potential simplification is to have a utility private method as part of |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In BaseChatAgent implementation, the default implementation for ```on_messages`` is blank:
and the default implementation for
on_messages_stream
is based onon_messages
:However, in AssistantAgent, the relationship is reversed: the implementation of
on_messages
is based onon_messages_stream
:I think it is more elegant to reverse their relationship in BaseChatAgent. When the developer want to cutomize a new BaseChatAgent, the developer only needs to instantiate the
on_messages_stream
method.Beta Was this translation helpful? Give feedback.
All reactions