Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin store for PowerToys #7180

Closed
ghost opened this issue Oct 8, 2020 · 14 comments
Closed

Plugin store for PowerToys #7180

ghost opened this issue Oct 8, 2020 · 14 comments

Comments

@ghost
Copy link

ghost commented Oct 8, 2020

📝 Provide a description of the new feature

What is the expected behavior of the proposed feature? What is the scenario this would be used?

This will allow the users to download and install plugins for PowerToys from the PowerToys settings user interface


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 8, 2020
@ghost
Copy link
Author

ghost commented Oct 8, 2020

Kind of related to #3200

@enricogior
Copy link
Contributor

Are you referring to PT Run plug-ins?

@ghost
Copy link
Author

ghost commented Oct 8, 2020

@enricogior

Well I don't know anything about PT plugins. I have heard about them but it would be more accessible if we have something like a plugin store. When I think of plugins I think new features like more powertoys that are not there by default and new features to existing powertoys. Not just PT Run

@ghost
Copy link
Author

ghost commented Oct 8, 2020

Kind of like the extension marketplace in Visual Studio and Visual Studio Code

@ghost
Copy link
Author

ghost commented Oct 8, 2020

I saw a PT plugin kind of thing in GitHub: khanhas/fancytiling

The installation process for it seems difficult compared to having a plugin store that will do all the work for you

@enricogior
Copy link
Contributor

We don't have any plans for plugins in PT, and given the way PT modules work, plug-ins don't fit in the PT architecture.

@Aaron-Junker
Copy link
Collaborator

Aaron-Junker commented Oct 8, 2020

So should I close this issue?

Yes

@ghost
Copy link
Author

ghost commented Oct 8, 2020

@enricogior Is it possible to modify existing module's dll file?

@Aaron-Junker Aaron-Junker added Resolution-Won't fix and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 8, 2020
@ghost
Copy link
Author

ghost commented Oct 8, 2020

That's how the 'plugin' that I mentioned above works

NOTE: I have not tried using that plugin

@ghost
Copy link
Author

ghost commented Oct 8, 2020

@Aaron-Junker please wait a minute before we close this (hopefully not)

@ghost
Copy link
Author

ghost commented Oct 8, 2020

  • Download fancyzones.dll
  • Save it to C:\Program Files\PowerToys\modules\FancyZones. Since PowerToys has not supported custom module name so just paste and replace the original fancyzones.dll. Back it up if you want. Note: Your path to PowerToys folder might be different
  • Restart PowerToys

This is the setup instructions for that 'plugin'.
If we make a plugin store that would replace the original dll file, I think it would work.

BTW, I haven't tried using this plugin and I don't know whether this will work

@ghost
Copy link
Author

ghost commented Oct 8, 2020

@enricogior @Aaron-Junker

If this ☝️ method is not possible to implement then I will close the issue

@enricogior
Copy link
Contributor

enricogior commented Oct 8, 2020

Is it possible to modify existing module's dll file?

In theory is possible but in general it won't work in the current architecture.

If we make a plugin store that would replace the original dll file, I think it would work.

We don't have any plan to support such a feature, it would open the door to so many problems that would basically kill the project. We are a small team and a plug-in approach would require to rewrite a significant amount of code and it will be very complicated to support it. Can you imagine just the waste of time to try to replicate issues that may occur only with a particular list of plug-ins?
We only support the one version for each module, and only the latest PT release with all the latest modules.

@ghost
Copy link
Author

ghost commented Oct 8, 2020

Ok. That makes sense

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants