Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IAsyncTexlFunction4 and IAsyncTexlFunction5 #2818

Open
MikeStall opened this issue Jan 18, 2025 · 2 comments
Open

Remove IAsyncTexlFunction4 and IAsyncTexlFunction5 #2818

MikeStall opened this issue Jan 18, 2025 · 2 comments

Comments

@MikeStall
Copy link
Contributor

MikeStall commented Jan 18, 2025

These are used by implementatons from Fx.Json.

The challenge is that Fx.Json can't depend on Fx.Interpreter (because PAClient depends on Fx.Json).
That's a unique requirement - most everything else that wants to provide an interpreter implementation can safely depend on Fx.Interpreter. So we may need to special case something here. Perhaps a unique PowerFxJson contract that lives in core, is implemented by Fx.Json, and handled by Fx.Interpreter

@MikeStall
Copy link
Contributor Author

As part of this, IAsyncTexlFunction5 should not get its own ServiceProvider.

@anderson-joyle
Copy link
Contributor

A reminder that we will need to act on PFx.DV since IAsyncTexlFunction5 it is used also there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants