Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a guard on path #8163

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Add a guard on path #8163

merged 2 commits into from
Feb 5, 2025

Conversation

bschnurr
Copy link
Member

@bschnurr bschnurr commented Feb 5, 2025 •
edited
Loading

fix for workitem 2345868

@bschnurr bschnurr requested a review from a team as a code owner February 5, 2025 18:14
rchiodo
rchiodo approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the crash, but could the interpreter path being null cause a crash somewhere else?

The root cause is the interpreter path being null here:

PTVS/Python/Product/PythonTools/PythonTools/LanguageServerClient/PythonLanguageClient.cs

Lines 527 to 528 in 9e5040e

if (PathUtils.IsSubpathOf(context.RootPath, context.InterpreterConfiguration.InterpreterPath)) {
var pattern = CommonUtils.GetRelativeFilePath(context.RootPath, context.InterpreterConfiguration.GetPrefixPath()).TrimEnd('\\') + "/**/*";

@rchiodo
Copy link
Contributor

rchiodo commented Feb 5, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bschnurr
Copy link
Member Author

bschnurr commented Feb 5, 2025

/azdo run

@bschnurr bschnurr closed this Feb 5, 2025
@bschnurr bschnurr reopened this Feb 5, 2025
@bschnurr
Copy link
Member Author

bschnurr commented Feb 5, 2025

/azdo run

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bschnurr
Copy link
Member Author

bschnurr commented Feb 5, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StellaHuang95 StellaHuang95 merged commit 56c46b6 into microsoft:main Feb 5, 2025
6 checks passed
StellaHuang95 pushed a commit that referenced this pull request Feb 6, 2025
@bschnurr @StellaHuang95
Add a guard on path (#8163)
a6f9ab8 
* Add a guard on path

* remove glass tests
@StellaHuang95 StellaHuang95 mentioned this pull request Feb 6, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@StellaHuang95 StellaHuang95 StellaHuang95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bschnurr @rchiodo @StellaHuang95