Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Sarif.Sdk greater then 2.4.16 #1470

Open
BernieWhite opened this issue Mar 11, 2023 · 0 comments
Open

Move to Sarif.Sdk greater then 2.4.16 #1470

BernieWhite opened this issue Mar 11, 2023 · 0 comments
Labels
dependencies Changes for a dependency update feature: core Issues that affect the core engine help wanted Extra attention is needed .NET Pull requests that update .net code
Milestone
v4.0.0

Comments

@BernieWhite
Copy link
Member

BernieWhite commented Mar 11, 2023 •
edited
Loading

After Sarif.Sdk v2.4.16, the package reverted dependencies to only require a older version v9.0.1 (or newer) of Newtonsoft.Json then previously supported. This by default conflicts with Windows PowerShell because of the older style version pinning and binding redirects in .NET Framework.

Unfortunately we haven't been able to get this to work so far #1445.

While we still support Windows PowerShell we need to work around this. We're not going to drop support for Windows PowerShell with PSRule v3 but this will probably happen in v4.
@BernieWhite BernieWhite added enhancement New feature or request help wanted Extra attention is needed .NET Pull requests that update .net code dependencies Changes for a dependency update feature: core Issues that affect the core engine and removed enhancement New feature or request labels Mar 11, 2023
@BernieWhite BernieWhite added this to the v4.0.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Changes for a dependency update feature: core Issues that affect the core engine help wanted Extra attention is needed .NET Pull requests that update .net code
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@BernieWhite