fix: adds version 3.0.4 and 3.1.1 to supported versions #10247
+28
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@char0n since we've worked together on the spec and since you've contributed a lot on this project, I thought maybe you could help get this merged? |
|
Would be nice to get this fixed quickly. |
baywet
changed the title
|
Any news ? |
|
Any word on what the hold up is? |
|
@baywet - Maybe merge base branch in so this can continue to progress? |
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
baywet
force-pushed
the
fix/missing-version-304
branch
from
04cdd9c to
924aaa4
Compare
|
@richard-collette-precisely done! Let me know if anything else is needed to get this merged |
|
@baywet - We need a reviewer. Unfortunately I am not one of them. Thank you for the PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds version 3.0.4 to the list of supported versions
3.0.4 is a maintenance release of the specification that does not change any of the functional aspects.
https://www.openapis.org/blog/2024/10/25/announcing-openapi-specification-patch-releases
Motivation and Context
fixes microsoft/OpenAPI.NET#2030
How Has This Been Tested?
This has NOT been tested beyond the affected unit tests. However the changes are straightforward and minor, I do not expect any side effects.
I'd appreciate if anyone could take the time to pull and test this just for sanity.
Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests