Skip to content

Commit aad26b4

Browse files
committed
chore: removes duplicated serialize internal method
Signed-off-by: Vincent Biret <[email protected]>
1 parent 8c2c188 commit aad26b4

6 files changed

+14
-40
lines changed

src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs

+14
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using System;
12
using Microsoft.OpenApi.Interfaces;
23
using Microsoft.OpenApi.Writers;
34

@@ -76,4 +77,17 @@ protected BaseOpenApiReferenceHolder(string referenceId, OpenApiDocument hostDoc
7677
public abstract void SerializeAsV3(IOpenApiWriter writer);
7778
/// <inheritdoc/>
7879
public abstract void SerializeAsV31(IOpenApiWriter writer);
80+
81+
/// <summary>
82+
/// Serialize the reference as a reference or the target object.
83+
/// This method is used to accelerate the serialization methods implementations.
84+
/// </summary>
85+
/// <param name="writer">The OpenApiWriter.</param>
86+
/// <param name="action">The action to serialize the target object.</param>
87+
private protected void SerializeInternal(IOpenApiWriter writer,
88+
Action<IOpenApiWriter, V> action)
89+
{
90+
Utils.CheckArgumentNull(writer);
91+
action(writer, Target);
92+
}
7993
}

src/Microsoft.OpenApi/Models/References/OpenApiCallbackReference.cs

-8
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,5 @@ public override void SerializeAsV2(IOpenApiWriter writer)
8787
// examples components are not supported in OAS 2.0
8888
Reference.SerializeAsV2(writer);
8989
}
90-
91-
/// <inheritdoc/>
92-
private void SerializeInternal(IOpenApiWriter writer,
93-
Action<IOpenApiWriter, IOpenApiReferenceable> action)
94-
{
95-
Utils.CheckArgumentNull(writer);
96-
action(writer, Target);
97-
}
9890
}
9991
}

src/Microsoft.OpenApi/Models/References/OpenApiExampleReference.cs

-8
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,5 @@ public override void SerializeAsV2(IOpenApiWriter writer)
114114
// examples components are not supported in OAS 2.0
115115
Reference.SerializeAsV2(writer);
116116
}
117-
118-
/// <inheritdoc/>
119-
private void SerializeInternal(IOpenApiWriter writer,
120-
Action<IOpenApiWriter, IOpenApiExample> action)
121-
{
122-
Utils.CheckArgumentNull(writer);
123-
action(writer, Target);
124-
}
125117
}
126118
}

src/Microsoft.OpenApi/Models/References/OpenApiHeaderReference.cs

-8
Original file line numberDiff line numberDiff line change
@@ -130,13 +130,5 @@ public override IOpenApiHeader CopyReferenceAsTargetElementWithOverrides(IOpenAp
130130
{
131131
return source is OpenApiHeader ? new OpenApiHeader(this) : source;
132132
}
133-
134-
/// <inheritdoc/>
135-
private void SerializeInternal(IOpenApiWriter writer,
136-
Action<IOpenApiWriter, IOpenApiHeader> action)
137-
{
138-
Utils.CheckArgumentNull(writer);
139-
action(writer, Target);
140-
}
141133
}
142134
}

src/Microsoft.OpenApi/Models/References/OpenApiLinkReference.cs

-8
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,5 @@ public override IOpenApiLink CopyReferenceAsTargetElementWithOverrides(IOpenApiL
106106
{
107107
return source is OpenApiLink ? new OpenApiLink(this) : source;
108108
}
109-
110-
/// <inheritdoc/>
111-
private void SerializeInternal(IOpenApiWriter writer,
112-
Action<IOpenApiWriter, IOpenApiLink> action)
113-
{
114-
Utils.CheckArgumentNull(writer);
115-
action(writer, Target);
116-
}
117109
}
118110
}

src/Microsoft.OpenApi/Models/References/OpenApiParameterReference.cs

-8
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,5 @@ public override IOpenApiParameter CopyReferenceAsTargetElementWithOverrides(IOpe
137137
{
138138
return source is OpenApiParameter ? new OpenApiParameter(this) : source;
139139
}
140-
141-
/// <inheritdoc/>
142-
private void SerializeInternal(IOpenApiWriter writer,
143-
Action<IOpenApiWriter, IOpenApiParameter> action)
144-
{
145-
Utils.CheckArgumentNull(writer);
146-
action(writer, Target);
147-
}
148140
}
149141
}

0 commit comments

Comments
 (0)