WIP

Author: maxtropets

include/ccf/ds/nonstd.h

@@ -172,9 +172,18 @@ namespace ccf::nonstd
 
   /** These convert strings to upper or lower case, in-place
    */
-  void to_upper(std::string& s);
-
-  void to_lower(std::string& s);
+  static inline void to_upper(std::string& s)
+  {
+    std::transform(s.begin(), s.end(), s.begin(), [](unsigned char c) {
+      return std::toupper(c);
+    });
+  }
+  static inline void to_lower(std::string& s)
+  {
+    std::transform(s.begin(), s.end(), s.begin(), [](unsigned char c) {
+      return std::tolower(c);
+    });
+  }
 
   /// Iterate through tuple, calling functor on each element
   template <size_t I = 0, typename F, typename... Ts>

src/ds/nonstd.cpp

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the Apache 2.0 License.
 
-#include "ccf/ds/nonstd.h"
-
 #include "ds/nonstd.h"
 
 #include <algorithm>
@@ -14,21 +12,6 @@
 
 namespace ccf::nonstd
 {
-  // Implementations for ccf/ds/nonstd.h
-  void to_upper(std::string& s)
-  {
-    std::transform(s.begin(), s.end(), s.begin(), [](unsigned char c) {
-      return std::toupper(c);
-    });
-  }
-
-  void to_lower(std::string& s)
-  {
-    std::transform(s.begin(), s.end(), s.begin(), [](unsigned char c) {
-      return std::tolower(c);
-    });
-  }
-
   // Implementations for ds/nonstd.h
   std::string camel_case(
     std::string s, bool camel_first, const std::string& separator_regex)