Skip to content

Commit 7bceaaf

Browse files
authored
Build: add entry points without top level side-effects (#5329)
* Build: add entry points without top level side-effects * Update d.ts tests * Changelog * Polish build info
1 parent ae69d04 commit 7bceaaf

40 files changed

+319
-655
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
7373
- Resolved [#5302](https://github.com/microsoft/BotFramework-WebChat/issues/5302). Migrated to `core-js-pure/Promise.withResolveers` from `p-defer`, in PR [#5301](https://github.com/microsoft/BotFramework-WebChat/pull/5301), by [@compulim](https://github.com/compulim)
7474
- Improved message bubble layout in Fluent theme to allow growth beyond 450px up to 75% of container width, in PR [#5324](https://github.com/microsoft/BotFramework-WebChat/pull/5324), by [@OEvgeny](https://github.com/OEvgeny)
7575
- Improved drop zone behavior and styling in Fluent theme, in PR [#5328](https://github.com/microsoft/BotFramework-WebChat/pull/5328), by [@OEvgeny](https://github.com/OEvgeny)
76+
- Excluded side effects from module entry points to prevent global scope modifications, in PR [#5329](https://github.com/microsoft/BotFramework-WebChat/pull/5329), by [@OEvgeny](https://github.com/OEvgeny)
7677

7778
### Fixed
7879

__tests__/html/metaTag.webChat.es5.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
);
2727

2828
expect(buildInfo).toHaveProperty('build-tool', 'tsup');
29-
expect(buildInfo).toHaveProperty('module-format', 'esmodules');
29+
expect(buildInfo).toHaveProperty('module-format', 'global');
3030
expect(buildInfo).toHaveProperty('variant', 'full-es5');
3131
expect(buildInfo.version).toMatch(/^\d+\.\d+\.\d+($|-)/u);
3232
});

__tests__/html/metaTag.webChat.full.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
);
2727

2828
expect(buildInfo).toHaveProperty('build-tool', 'tsup');
29-
expect(buildInfo).toHaveProperty('module-format', 'esmodules');
29+
expect(buildInfo).toHaveProperty('module-format', 'global');
3030
expect(buildInfo).toHaveProperty('variant', 'full');
3131
expect(buildInfo.version).toMatch(/^\d+\.\d+\.\d+($|-)/u);
3232
});

__tests__/html/metaTag.webChat.minimal.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
);
2727

2828
expect(buildInfo).toHaveProperty('build-tool', 'tsup');
29-
expect(buildInfo).toHaveProperty('module-format', 'esmodules');
29+
expect(buildInfo).toHaveProperty('module-format', 'global');
3030
expect(buildInfo).toHaveProperty('variant', 'minimal');
3131
expect(buildInfo.version).toMatch(/^\d+\.\d+\.\d+($|-)/u);
3232
});

package-lock.json

+3-259
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)