Split workitem validation and labeling workflows #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Build: Automation
mazhelez
approved these changes
Feb 17, 2025
| shell: pwsh | ||
|
|
||
| jobs: | ||
| GitHubIssueValidation: |
There was a problem hiding this comment.
Shouldn't there be a check here that the parent workflow was successful?
| # If the pull request is not from a fork, add a comment to the pull request | ||
| if (-not $PullRequest.IsFromFork()) { | ||
| # If the pull request is not from a fork and not validate only, add a comment | ||
| if (-not $PullRequest.IsFromFork() -and -not $ValidateOnly) { |
There was a problem hiding this comment.
The pull requests: write permissions are only needed to add the comment, right?
How about we scratch that part? The workflow error should be descriptive enough.
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| build/scripts/PullRequestValidation/ValidateInternalWorkItemForPullRequest.ps1 -PullRequestNumber ${{github.event.workflow_run.pull_requests[0].number}} -Repository ${{ github.repository }} | ||
| - name: Add Linked label to PR |
There was a problem hiding this comment.
Suggested change
| - name: Add Linked label to PR | |
| - name: Add Linked label to PR |
| run: | | ||
| build/scripts/PullRequestValidation/AddMilestoneToPullRequest.ps1 -PullRequestNumber ${{github.event.workflow_run.pull_requests[0].number}} -Repository ${{ github.repository }} | ||
| Label: | ||
| name: 'Label pull request' |
There was a problem hiding this comment.
Is the same workflow, can't the two jobs be consolidated as well?
ankosiorek
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split workitem validation and labeling workflows
Work Item(s)
Fixes AB#565728