Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing environment settings. #2921

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

mynjj
Copy link

@mynjj mynjj commented Feb 11, 2025

Exposing the EnvironmentSettings for Microsoft published callers.

AB#565525

@github-actions github-actions bot modified the milestone: Version 26.0 Feb 11, 2025
@mynjj mynjj changed the title Environment Settings Exposing environment settings. Feb 11, 2025
@Groenbech96
Copy link
Contributor

Groenbech96 commented Feb 11, 2025

What does GetEnvironmentSetting actually return?
Does it give you any settings about the tenant environment? Like environment variables and such? Or is it only the data from the Clould Manager table?

@mynjj mynjj marked this pull request as ready for review February 11, 2025 10:05
@mynjj mynjj requested a review from a team as a code owner February 11, 2025 10:05
Copy link
Contributor

@darjoo darjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you even need this?
Do we know the exact values that EnvironmentSettings can contain?
From a security pov, I don't like this.

@mynjj
Copy link
Author

mynjj commented Feb 11, 2025

@darjoo

Why do you need this?

To control the visibility of the e-document flows that will not be visible in v26.0 when released, but that we still want feedback from private previews organized by the PM. The approach that was agreed on was to change a setting from Cloud Manager.

I added OnPrem, and the caller module filtering calls from "Microsoft" published apps.

Alternatively, we need an exception to call dotnet directly from the edocs app - that could be better than adding this, should I do that and abandon this PR?

@mynjj
Copy link
Author

mynjj commented Feb 12, 2025

paused until it goes through security review

@mynjj mynjj closed this Feb 12, 2025
@mynjj mynjj reopened this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants