From fceffe5a16b3dd67f9b8f44fc376c8d606868128 Mon Sep 17 00:00:00 2001 From: diegojoshuam Date: Tue, 11 Feb 2025 10:17:09 +0100 Subject: [PATCH 1/4] environment settings --- .../src/EnvironmentInformation.Codeunit.al | 10 ++++++++++ .../src/EnvironmentInformationImpl.Codeunit.al | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al b/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al index cce3ca73c2..af4b40ea08 100644 --- a/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al +++ b/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al @@ -127,4 +127,14 @@ codeunit 457 "Environment Information" exit(EnvironmentInformationImpl.GetLinkedPowerPlatformEnvironmentId()); end; + /// + /// Gets the value of the specified environment setting. This is only callable from Microsoft published apps. + /// + /// The name of the setting. + /// The value of the setting. + procedure GetEnvironmentSetting(SettingName: Text): Text + begin + exit(EnvironmentInformationImpl.GetEnvironmentSetting(SettingName)); + end; + } diff --git a/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al b/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al index 6a90407f93..586596c04c 100644 --- a/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al +++ b/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al @@ -148,6 +148,16 @@ codeunit 3702 "Environment Information Impl." exit(NavTenantSettingsHelper.GetLinkedPowerPlatformEnvironmentId()); end; + procedure GetEnvironmentSetting(SettingName: Text): Text + var + ModuleInfo: ModuleInfo; + begin + NavApp.GetCallerModuleInfo(ModuleInfo); + if ModuleInfo.Publisher <> 'Microsoft' then + exit(''); + exit(NavTenantSettingsHelper.GetEnvironmentSetting(SettingName)); + end; + [InternalEvent(false)] procedure OnBeforeGetApplicationIdentifier(var AppId: Text) begin From e1ab8ae206e660269d738199658151e647feddf0 Mon Sep 17 00:00:00 2001 From: diegojoshuam Date: Tue, 11 Feb 2025 11:17:32 +0100 Subject: [PATCH 2/4] onpremm --- .../src/EnvironmentInformation.Codeunit.al | 1 + 1 file changed, 1 insertion(+) diff --git a/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al b/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al index af4b40ea08..8c13ba52da 100644 --- a/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al +++ b/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al @@ -132,6 +132,7 @@ codeunit 457 "Environment Information" /// /// The name of the setting. /// The value of the setting. + [Scope('OnPrem')] procedure GetEnvironmentSetting(SettingName: Text): Text begin exit(EnvironmentInformationImpl.GetEnvironmentSetting(SettingName)); From 487249e847b68eca8fc589adec563da7b99d05e4 Mon Sep 17 00:00:00 2001 From: diegojoshuam Date: Tue, 11 Feb 2025 11:22:43 +0100 Subject: [PATCH 3/4] moving callermodule to the facade --- .../src/EnvironmentInformation.Codeunit.al | 5 ++++- .../src/EnvironmentInformationImpl.Codeunit.al | 5 +---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al b/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al index 8c13ba52da..272f213563 100644 --- a/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al +++ b/src/System Application/App/Environment Information/src/EnvironmentInformation.Codeunit.al @@ -134,8 +134,11 @@ codeunit 457 "Environment Information" /// The value of the setting. [Scope('OnPrem')] procedure GetEnvironmentSetting(SettingName: Text): Text + var + ModuleInfo: ModuleInfo; begin - exit(EnvironmentInformationImpl.GetEnvironmentSetting(SettingName)); + NavApp.GetCallerModuleInfo(ModuleInfo); + exit(EnvironmentInformationImpl.GetEnvironmentSetting(SettingName, ModuleInfo)); end; } diff --git a/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al b/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al index 586596c04c..624ceb4756 100644 --- a/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al +++ b/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al @@ -148,11 +148,8 @@ codeunit 3702 "Environment Information Impl." exit(NavTenantSettingsHelper.GetLinkedPowerPlatformEnvironmentId()); end; - procedure GetEnvironmentSetting(SettingName: Text): Text - var - ModuleInfo: ModuleInfo; + procedure GetEnvironmentSetting(SettingName: Text; ModuleInfo: ModuleInfo): Text begin - NavApp.GetCallerModuleInfo(ModuleInfo); if ModuleInfo.Publisher <> 'Microsoft' then exit(''); exit(NavTenantSettingsHelper.GetEnvironmentSetting(SettingName)); From 1885932a318ed3c2611cfb7ed0f0bec789c51074 Mon Sep 17 00:00:00 2001 From: diegojoshuam Date: Fri, 21 Feb 2025 17:31:53 +0100 Subject: [PATCH 4/4] . --- .../src/EnvironmentInformationImpl.Codeunit.al | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al b/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al index 624ceb4756..bcb34e2dad 100644 --- a/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al +++ b/src/System Application/App/Environment Information/src/EnvironmentInformationImpl.Codeunit.al @@ -152,7 +152,7 @@ codeunit 3702 "Environment Information Impl." begin if ModuleInfo.Publisher <> 'Microsoft' then exit(''); - exit(NavTenantSettingsHelper.GetEnvironmentSetting(SettingName)); + exit(NavTenantSettingsHelper.GetEnvironmentApplicationSetting(SettingName)); end; [InternalEvent(false)]