Skip to content

Commit 80a3318

Browse files
authored
Remove NonDebuggable SharePoint Module (#874)
#### Summary This PR remove NonDebuggable property from parts of the SharePoint module because the values are already debuggable in an upper level and there are are no secrets. #### Work Item(s) Fixes #854 Fixes [AB#524171](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/524171) Fixes [AB#524072](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/524072)
1 parent cc7c686 commit 80a3318

8 files changed

+0
-40
lines changed

src/System Application/App/SharePoint/src/Diagnostics/SharePointDiagnostics.codeunit.al

-6
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ codeunit 9111 "SharePoint Diagnostics" implements "HTTP Diagnostics"
2323
/// Gets reponse details.
2424
/// </summary>
2525
/// <returns>HttpResponseMessage.IsSuccessStatusCode</returns>
26-
[NonDebuggable]
2726
procedure IsSuccessStatusCode(): Boolean
2827
begin
2928
exit(SuccessStatusCode);
@@ -33,7 +32,6 @@ codeunit 9111 "SharePoint Diagnostics" implements "HTTP Diagnostics"
3332
/// Gets response details.
3433
/// </summary>
3534
/// <returns>HttpResponseMessage.StatusCode</returns>
36-
[NonDebuggable]
3735
procedure GetHttpStatusCode(): Integer
3836
begin
3937
exit(HttpStatusCode);
@@ -43,7 +41,6 @@ codeunit 9111 "SharePoint Diagnostics" implements "HTTP Diagnostics"
4341
/// Gets response details.
4442
/// </summary>
4543
/// <returns>Retry-after header value</returns>
46-
[NonDebuggable]
4744
procedure GetHttpRetryAfter(): Integer
4845
begin
4946
exit(RetryAfter);
@@ -53,7 +50,6 @@ codeunit 9111 "SharePoint Diagnostics" implements "HTTP Diagnostics"
5350
/// Gets reponse details
5451
/// </summary>
5552
/// <returns>Error message</returns>
56-
[NonDebuggable]
5753
procedure GetErrorMessage(): Text
5854
begin
5955
exit(ErrorMessage);
@@ -63,13 +59,11 @@ codeunit 9111 "SharePoint Diagnostics" implements "HTTP Diagnostics"
6359
/// Gets response details.
6460
/// </summary>
6561
/// <returns>HttpResponseMessage.ResponseReasonPhrase</returns>
66-
[NonDebuggable]
6762
procedure GetResponseReasonPhrase(): Text
6863
begin
6964
exit(ResponseReasonPhrase);
7065
end;
7166

72-
[NonDebuggable]
7367
internal procedure SetParameters(NewIsSuccesss: Boolean; NewHttpStatusCode: Integer; NewResponseReasonPhrase: Text; NewRetryAfter: Integer; NewErrorMessage: Text)
7468
begin
7569
SuccessStatusCode := NewIsSuccesss;

src/System Application/App/SharePoint/src/helpers/SharePointOperationResponse.Codeunit.al

-8
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ codeunit 9108 "SharePoint Operation Response"
1313
InherentEntitlements = X;
1414
InherentPermissions = X;
1515

16-
[NonDebuggable]
1716
[TryFunction]
1817
internal procedure GetResultAsText(var Result: Text);
1918
var
@@ -23,14 +22,12 @@ codeunit 9108 "SharePoint Operation Response"
2322
ResultInStream.ReadText(Result);
2423
end;
2524

26-
[NonDebuggable]
2725
[TryFunction]
2826
internal procedure GetResultAsStream(var ResultInStream: InStream)
2927
begin
3028
TempBlobContent.CreateInStream(ResultInStream);
3129
end;
3230

33-
[NonDebuggable]
3431
internal procedure SetHttpResponse(HttpResponseMessage: HttpResponseMessage)
3532
var
3633
ContentOutStream: OutStream;
@@ -43,7 +40,6 @@ codeunit 9108 "SharePoint Operation Response"
4340
SharepointDiagnostics.SetParameters(HttpResponseMessage.IsSuccessStatusCode, HttpResponseMessage.HttpStatusCode, HttpResponseMessage.ReasonPhrase, GetRetryAfterHeaderValue(), GetErrorDescription());
4441
end;
4542

46-
[NonDebuggable]
4743
internal procedure SetHttpResponse(ResponseContent: Text; ResponseHttpHeaders: HttpHeaders; ResponseHttpStatusCode: Integer; ResponseIsSuccessStatusCode: Boolean; ResponseReasonPhrase: Text)
4844
var
4945
ContentOutStream: OutStream;
@@ -54,7 +50,6 @@ codeunit 9108 "SharePoint Operation Response"
5450
SharepointDiagnostics.SetParameters(ResponseIsSuccessStatusCode, ResponseHttpStatusCode, ResponseReasonPhrase, GetRetryAfterHeaderValue(), GetErrorDescription());
5551
end;
5652

57-
[NonDebuggable]
5853
internal procedure GetHeaderValueFromResponseHeaders(HeaderName: Text): Text
5954
var
6055
Values: array[100] of Text;
@@ -66,7 +61,6 @@ codeunit 9108 "SharePoint Operation Response"
6661
exit(Values[1]);
6762
end;
6863

69-
[NonDebuggable]
7064
internal procedure GetRetryAfterHeaderValue() RetryAfter: Integer;
7165
var
7266
HeaderValue: Text;
@@ -78,7 +72,6 @@ codeunit 9108 "SharePoint Operation Response"
7872
exit(0);
7973
end;
8074

81-
[NonDebuggable]
8275
local procedure GetErrorDescription(): Text
8376
var
8477
Result: Text;
@@ -92,7 +85,6 @@ codeunit 9108 "SharePoint Operation Response"
9285
exit(JToken.AsValue().AsText());
9386
end;
9487

95-
[NonDebuggable]
9688
internal procedure GetDiagnostics(): Interface "HTTP Diagnostics"
9789
begin
9890
exit(SharepointDiagnostics);

src/System Application/App/SharePoint/src/helpers/SharePointRequestHelper.Codeunit.al

-3
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ codeunit 9109 "SharePoint Request Helper"
5151
OperationResponse := SendRequest(PrepareRequestMsg("Http Request Type"::DELETE, SharePointUriBuilder));
5252
end;
5353

54-
[NonDebuggable]
5554
local procedure PrepareRequestMsg(HttpRequestType: Enum "Http Request Type"; SharePointUriBuilder: Codeunit "SharePoint Uri Builder") RequestMessage: HttpRequestMessage
5655
var
5756
Headers: HttpHeaders;
@@ -63,7 +62,6 @@ codeunit 9109 "SharePoint Request Helper"
6362
Headers.Add('User-Agent', GetUserAgentString());
6463
end;
6564

66-
[NonDebuggable]
6765
local procedure PrepareRequestMsg(HttpRequestType: Enum "Http Request Type"; SharePointUriBuilder: Codeunit "SharePoint Uri Builder"; SharePointHttpContent: Codeunit "SharePoint Http Content") RequestMessage: HttpRequestMessage
6866
var
6967
Headers: HttpHeaders;
@@ -99,7 +97,6 @@ codeunit 9109 "SharePoint Request Helper"
9997
end;
10098
end;
10199

102-
[NonDebuggable]
103100
local procedure SendRequest(HttpRequestMessage: HttpRequestMessage) OperationResponse: Codeunit "SharePoint Operation Response"
104101
var
105102
HttpResponseMessage: HttpResponseMessage;

src/System Application/App/SharePoint/src/model/file/SharePointFile.Codeunit.al

-5
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ codeunit 9106 "SharePoint File"
1111
InherentEntitlements = X;
1212
InherentPermissions = X;
1313

14-
[NonDebuggable]
1514
procedure Parse(Payload: Text; var SharePointFile: Record "SharePoint File" temporary)
1615
var
1716
JObject: JsonObject;
@@ -20,7 +19,6 @@ codeunit 9106 "SharePoint File"
2019
Parse(JObject, SharePointFile);
2120
end;
2221

23-
[NonDebuggable]
2422
procedure ParseSingleReturnValue(Payload: Text; var SharePointFile: Record "SharePoint File" temporary)
2523
var
2624
JObject: JsonObject;
@@ -34,7 +32,6 @@ codeunit 9106 "SharePoint File"
3432
end;
3533
end;
3634

37-
[NonDebuggable]
3835
procedure ParseSingle(Payload: Text; var SharePointFile: Record "SharePoint File" temporary)
3936
var
4037
JObject: JsonObject;
@@ -43,7 +40,6 @@ codeunit 9106 "SharePoint File"
4340
SharePointFile := ParseSingle(JObject);
4441
end;
4542

46-
[NonDebuggable]
4743
procedure Parse(Payload: JsonObject; var SharePointFile: Record "SharePoint File" temporary)
4844
var
4945
JToken: JsonToken;
@@ -55,7 +51,6 @@ codeunit 9106 "SharePoint File"
5551
end;
5652
end;
5753

58-
[NonDebuggable]
5954
local procedure ParseSingle(Payload: JsonObject) SharePointFile: Record "SharePoint File" temporary
6055
var
6156
SharePointClient: Codeunit "SharePoint Client";

src/System Application/App/SharePoint/src/model/folder/SharePointFolder.Codeunit.al

-5
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ codeunit 9105 "SharePoint Folder"
1111
InherentEntitlements = X;
1212
InherentPermissions = X;
1313

14-
[NonDebuggable]
1514
procedure Parse(Payload: Text; var SharePointFolder: Record "SharePoint Folder" temporary)
1615
var
1716
JObject: JsonObject;
@@ -20,7 +19,6 @@ codeunit 9105 "SharePoint Folder"
2019
Parse(JObject, SharePointFolder);
2120
end;
2221

23-
[NonDebuggable]
2422
procedure Parse(Payload: JsonObject; var SharePointFolder: Record "SharePoint Folder" temporary)
2523
var
2624
JToken: JsonToken;
@@ -32,7 +30,6 @@ codeunit 9105 "SharePoint Folder"
3230
end;
3331
end;
3432

35-
[NonDebuggable]
3633
procedure ParseSingleReturnValue(Payload: Text; var SharePointFolder: Record "SharePoint Folder" temporary)
3734
var
3835
JObject: JsonObject;
@@ -46,7 +43,6 @@ codeunit 9105 "SharePoint Folder"
4643
end;
4744
end;
4845

49-
[NonDebuggable]
5046
procedure ParseSingle(Payload: Text; var SharePointFolder: Record "SharePoint Folder" temporary)
5147
var
5248
JObject: JsonObject;
@@ -57,7 +53,6 @@ codeunit 9105 "SharePoint Folder"
5753
end;
5854
end;
5955

60-
[NonDebuggable]
6156
local procedure ParseSingle(Payload: JsonObject) SharePointFolder: Record "SharePoint Folder" temporary
6257
var
6358
JToken: JsonToken;

src/System Application/App/SharePoint/src/model/list/SharePointList.Codeunit.al

-4
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ codeunit 9104 "SharePoint List"
1111
InherentEntitlements = X;
1212
InherentPermissions = X;
1313

14-
[NonDebuggable]
1514
procedure Parse(Payload: Text; var SharePointList: Record "SharePoint List" temporary)
1615
var
1716
JObject: JsonObject;
@@ -20,7 +19,6 @@ codeunit 9104 "SharePoint List"
2019
Parse(JObject, SharePointList);
2120
end;
2221

23-
[NonDebuggable]
2422
procedure Parse(Payload: JsonObject; var SharePointList: Record "SharePoint List" temporary)
2523
var
2624
JToken: JsonToken;
@@ -32,7 +30,6 @@ codeunit 9104 "SharePoint List"
3230
end;
3331
end;
3432

35-
[NonDebuggable]
3633
procedure ParseSingleReturnValue(Payload: Text; var SharePointList: Record "SharePoint List" temporary)
3734
var
3835
JObject: JsonObject;
@@ -46,7 +43,6 @@ codeunit 9104 "SharePoint List"
4643
end;
4744
end;
4845

49-
[NonDebuggable]
5046
local procedure ParseSingle(Payload: JsonObject) SharePointList: Record "SharePoint List" temporary
5147
var
5248
JToken: JsonToken;

src/System Application/App/SharePoint/src/model/listitem/SharePointListItem.Codeunit.al

-4
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ codeunit 9103 "SharePoint List Item"
1111
InherentEntitlements = X;
1212
InherentPermissions = X;
1313

14-
[NonDebuggable]
1514
procedure Parse(Payload: Text; var SharePointListItem: Record "SharePoint List Item" temporary)
1615
var
1716
JObject: JsonObject;
@@ -20,7 +19,6 @@ codeunit 9103 "SharePoint List Item"
2019
Parse(JObject, SharePointListItem);
2120
end;
2221

23-
[NonDebuggable]
2422
procedure Parse(Payload: JsonObject; var SharePointListItem: Record "SharePoint List Item" temporary)
2523
var
2624
JToken: JsonToken;
@@ -32,7 +30,6 @@ codeunit 9103 "SharePoint List Item"
3230
end;
3331
end;
3432

35-
[NonDebuggable]
3633
procedure ParseSingleReturnValue(Payload: Text; var SharePointListItem: Record "SharePoint List Item" temporary)
3734
var
3835
JObject: JsonObject;
@@ -46,7 +43,6 @@ codeunit 9103 "SharePoint List Item"
4643
end;
4744
end;
4845

49-
[NonDebuggable]
5046
local procedure ParseSingle(Payload: JsonObject) SharePointListItem: Record "SharePoint List Item" temporary
5147
var
5248
SharePointUriBuilder: Codeunit "SharePoint Uri Builder";

src/System Application/App/SharePoint/src/model/listitemattachment/SharePointListItemAtch.Codeunit.al

-5
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ codeunit 9102 "SharePoint List Item Atch."
1111
InherentEntitlements = X;
1212
InherentPermissions = X;
1313

14-
[NonDebuggable]
1514
procedure Parse(Payload: Text; var SharePointListItemAtch: Record "SharePoint List Item Atch" temporary)
1615
var
1716
JObject: JsonObject;
@@ -20,7 +19,6 @@ codeunit 9102 "SharePoint List Item Atch."
2019
Parse(JObject, SharePointListItemAtch);
2120
end;
2221

23-
[NonDebuggable]
2422
procedure Parse(Payload: JsonObject; var SharePointListItemAtch: Record "SharePoint List Item Atch" temporary)
2523
var
2624
JToken: JsonToken;
@@ -32,7 +30,6 @@ codeunit 9102 "SharePoint List Item Atch."
3230
end;
3331
end;
3432

35-
[NonDebuggable]
3633
procedure ParseSingleReturnValue(Payload: Text; var SharePointListItemAtch: Record "SharePoint List Item Atch" temporary)
3734
var
3835
JObject: JsonObject;
@@ -46,7 +43,6 @@ codeunit 9102 "SharePoint List Item Atch."
4643
end;
4744
end;
4845

49-
[NonDebuggable]
5046
procedure ParseSingle(Payload: Text; var SharePointListItemAtch: Record "SharePoint List Item Atch" temporary)
5147
var
5248
JObject: JsonObject;
@@ -55,7 +51,6 @@ codeunit 9102 "SharePoint List Item Atch."
5551
SharePointListItemAtch := ParseSingle(JObject);
5652
end;
5753

58-
[NonDebuggable]
5954
local procedure ParseSingle(Payload: JsonObject) SharePointListItemAttachment: Record "SharePoint List Item Atch" temporary
6055
var
6156
SharePointUriBuilder: Codeunit "SharePoint Uri Builder";

0 commit comments

Comments
 (0)