Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensibility Request] Make parameter var in FindItemReferenceForSalesLine - Codeunit "Item Reference Management" #28192

Open
dannoe opened this issue Feb 20, 2025 · 0 comments

Comments

@dannoe
Copy link

dannoe commented Feb 20, 2025

Describe the request

-   local procedure FindItemReferenceForSalesLine(SalesLine: Record "Sales Line")
+   local procedure FindItemReferenceForSalesLine(var SalesLine: Record "Sales Line")
    var
        ToDate: Date;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeFindItemReferenceForSalesLine(SalesLine, GlobalItemReference, Found, IsHandled);
        if IsHandled then
            exit;

        GlobalItemReference.Reset();
        GlobalItemReference.SetRange("Item No.", SalesLine."No.");
        GlobalItemReference.SetRange("Variant Code", SalesLine."Variant Code");
        GlobalItemReference.SetRange("Unit of Measure", SalesLine."Unit of Measure Code");
        ToDate := SalesLine.GetDateForCalculations();
        if ToDate <> 0D then begin
            GlobalItemReference.SetFilter("Starting Date", '<=%1', ToDate);
            GlobalItemReference.SetFilter("Ending Date", '>=%1|%2', ToDate, 0D);
        end;
        GlobalItemReference.SetRange("Reference Type", SalesLine."Item Reference Type"::Customer);
        GlobalItemReference.SetRange("Reference Type No.", SalesLine."Sell-to Customer No.");
        GlobalItemReference.SetRange("Reference No.", SalesLine."Item Reference No.");
        OnFindItemReferenceForSalesLineOnBeforeFindFirst(SalesLine, GlobalItemReference);
        if GlobalItemReference.FindFirst() then
            Found := true
        else begin
            GlobalItemReference.SetRange("Reference No.");
            Found := GlobalItemReference.FindFirst();
        end;

        OnAfterFindItemReferenceForSalesLine(SalesLine, GlobalItemReference, Found);
    end;
    [IntegrationEvent(false, false)]
-   local procedure OnBeforeFindItemReferenceForSalesLine(SalesLine: Record "Sales Line"; var ItemReference: Record "Item Reference"; var Found: Boolean; var IsHandled: Boolean)
+   local procedure OnBeforeFindItemReferenceForSalesLine(var SalesLine: Record "Sales Line"; var ItemReference: Record "Item Reference"; var Found: Boolean; var IsHandled: Boolean)
    begin
    end;

Additional context

We need to transfer state via var. The function for the purchase side is already declared with var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant