Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC Idea]: Shopify: Save and expose Product Creation Errors #26610

Open
1 task done
eivindgiske opened this issue Jun 6, 2024 · 5 comments
Open
1 task done

[BC Idea]: Shopify: Save and expose Product Creation Errors #26610

eivindgiske opened this issue Jun 6, 2024 · 5 comments
Assignees
Labels
approved The issue is approved bcidea Issue is created based on a BC Idea Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item

Comments

@eivindgiske
Copy link

eivindgiske commented Jun 6, 2024

BC Idea Link

https://experience.dynamics.com/ideas/idea/?ideaid=9f0096c1-f9c4-ee11-92bd-000d3a058698

Description

At the moment, the Shopify Connector for Dynamics 365 Business Central does not have error handling on Product Sync (Creation in BC). As an end user, BC Items may not be created, and the error message is only available using VS Code debugger.

The Shopify Products page should have an Error Message field, like Shopify Orders, so that users are able to handle errors in product creation without being dependent on BC Developers.

The hidden error message is stored in variable ErrMsg: Text in codeunit 30185 "Shpfy Sync Products"

I will provide the implementation for this BC Idea

  • I will provide the implementation for this BC Idea
    Internal work item: AB#540964
@eivindgiske eivindgiske added the bcidea Issue is created based on a BC Idea label Jun 6, 2024
@eivindgiske eivindgiske changed the title [BC Idea]: Save and expose Product Creation Errors [BC Idea]: Shopify: Save and expose Product Creation Errors Jun 6, 2024
@JesperSchulz
Copy link
Contributor

@AndreiPanko / @onbuyuka, could you triage this idea, please?

@AndreiPanko
Copy link
Contributor

@eivindgiske
I understand your scenario is about converting imported Shopify Product to Item in Business Central. We haven't heard any feedback about that (except number series to run out of numbers). Would be interesting to learn where do you see errors?

Also there is no action to create item from product (variant), only mapping. So once user sees the error and solves the underlying bloker (changes no series), what is the action for them to take?

@eivindgiske
Copy link
Author

Hi @AndreiPanko.

We have implented BC onto an existing Shopify environment, and have used a setup where Shopify (and PIM) are Master for Product information.

Using this setup in BC Shopify Shop, the following business logic will execute.

  • Sync Item: From Shopify
  • Auto Create Unknown Items: TRUE

Report _"Shpfy Sync Products" will execute Codeunit "Shpfy Product Import" which in turn will evaluate whether an item exists or not, and execute Codeunit "Shpfy Create Item" if an item is unknown to BC. You are correct, there is no Action on the Page Shopify Products to do this manually, but it runs on the product sync.

There are integration events on Codeunit "Shpfy Create Item" that we use to control other aspects of product information. Things might fail for a number of reasons other than No. Series.

I cannot see why a partial error handling has been implemented, but is not stored on the Shopify Products record, and we urgently need this in place.

@AndreiPanko
Copy link
Contributor

There are integration events on Codeunit "Shpfy Create Item" that we use to control other aspects of product information. Things might fail for a number of reasons other than No. Series.

Good point about extensibility. @JesperSchulz what are the next steps?

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jun 18, 2024
@JesperSchulz
Copy link
Contributor

We approve this issue and wait for a PR 🙂

@JesperSchulz JesperSchulz added the approved The issue is approved label Jun 19, 2024
@bcbuild-github-agent bcbuild-github-agent added the linked Issue is linked to a Azure Boards work item label Jul 11, 2024
@AndreiPanko AndreiPanko added blocked The PR is blocked. See comments for the reason approved The issue is approved and removed approved The issue is approved blocked The PR is blocked. See comments for the reason labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The issue is approved bcidea Issue is created based on a BC Idea Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item
Projects
None yet
Development

No branches or pull requests

5 participants