Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: What is causing the issue in Az.KeyVault? and How we can resolve it? #1424

Closed
XPLJohnPalma opened this issue Jan 29, 2025 · 9 comments
Assignees
Labels
Fix Ready Fix Ready question Further information is requested

Comments

@XPLJohnPalma
Copy link

Question

Hi

Last 2weeks, we can build perfectly fine.

Image

but when tried it again last night, this happened

Image

May, we know what was the cause of this issue, and how we can resolve it?

@XPLJohnPalma XPLJohnPalma added the question Further information is requested label Jan 29, 2025
@freddydk
Copy link
Contributor

You are using a very old version of AL-Go for GitHub

I think what happened here is that the GitHub runners have a different version of various modules installed and v4.1 of AL-Go doesn't work with future installed bits.

If your GhTokenWorkflow secret is in Azure KeyVault - you might need to create the secret in GitHub to run the Update AL-Go system Files.

@freddydk freddydk added the Fix Ready Fix Ready label Jan 30, 2025
@XPLJohnPalma
Copy link
Author

XPLJohnPalma commented Feb 3, 2025

Hi Freddy,

Thank you for your assistance, we created the GhTokenWorkflow secret in GitHub and run "Update AL-Go system Files", however, we got the same error from the build

error from the build:
Image

error from the Update AL-Go system files:
Image

@freddydk
Copy link
Contributor

freddydk commented Feb 3, 2025

The error in the build will be the same until you have successfully run and merged updates to AL-Go System Files.
It looks like your GhTokenWorkflow secret wasn't created in the GitHub environment? Did you place it in an Azure KeyVault?
Since the problem with this old version is the connection to the keyvault - that won't work.

You might need to remove the Azure_Credentials secret (or if it is an organizational secret - remove access from the repo) - and then create the GhTokenWorkflow secret in the repository.

@XPLJohnPalma
Copy link
Author

Hi Freddy,

Thank you very much for your assistance :)

We have successfully updated the AL Go System File

Image

and it created a new branch and tried to build, however, another error occurred.

Image

What should be the next step?

@freddydk
Copy link
Contributor

You need to merge the pull request, then the next build from your main branch should be fine

@freddydk
Copy link
Contributor

Did this solve the issue?

@freddydk freddydk self-assigned this Feb 11, 2025
@XPLJohnPalma
Copy link
Author

Hi Freddy,

Yes, it is fixed now, thank you very much for your assistance.

@bernhardpluteo
Copy link

Good Morning @freddydk

We came across the same issue, we followed your steps and the "Read Secrets" works, but now we have an issue with the Codesigning(DigiCert in Azure Key Vault) of the Extension as we had to remove the Azure_Credentials form the Repo's secrets. Where must one define the Azure_Credentials now if one has the Codesign Cert in Azure Key Vault ?

@freddydk
Copy link
Contributor

@bernhardpluteo - once you have updated AL-Go System Files, I think everything should work fine and you can put the secret back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Ready Fix Ready question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants