Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Disable auto builds for all Pull Requests #1414

Open
StefanMaron opened this issue Jan 23, 2025 · 6 comments
Open

[Question]: Disable auto builds for all Pull Requests #1414

StefanMaron opened this issue Jan 23, 2025 · 6 comments
Labels
question Further information is requested

Comments

@StefanMaron
Copy link

Question

I did search through the various documentation files and trough open and closed issues, but did not find an answer to this question.

Is is possible to disable the automatic builds on all pull request entirely? I would still like to have the checks in place but I want to start the build manually once all changes are checken in. If the build is automatically started on any push, it consumes a lot of minutes which is not needed.

The only thing I found was CICDPullRequestBranches which I could set to [] I assume, but I am not sure if that will have the desired effect.

@StefanMaron StefanMaron added the question Further information is requested label Jan 23, 2025
@freddydk
Copy link
Contributor

We have been talking about not running builds while PRs are in Draft mode - but I don't think it ever made it in
Would this be what you are looking for?

@StefanMaron
Copy link
Author

It would be, but draft PRs are not always available for private Repos.

Image

@StefanMaron
Copy link
Author

Update: CICDPullRequestBranches: [] does not change anything, tested via ALGOORGSETTINGS

@freddydk
Copy link
Contributor

freddydk commented Jan 23, 2025

I think that an empty branches setting will cause it to become the default.

You could set the CICDPullRequestBranches to [ "dummy" ] - and then, it will only build PRs targeting the dummy branch (i.e. never)

Alternatively, you could keep the default and create a dev branch and a staging branch.
PR open from dev to staging.
PR open from staging to main
When you are done developing you merge into staging and now the builds will start.

@StefanMaron
Copy link
Author

You could set the CICDPullRequestBranches to [ "dummy" ] - and then, it will only build PRs targeting the dummy branch (i.e. never)

This does not seem to work either. I might just not create a PR until the branch is ready.
But the Draft PR approach would probably be the best solution. Maybe you could add an option to not start the builds for "regular" PRs that have [Draft] at the beginning of the title :)

@freddydk
Copy link
Contributor

Did you run Update AL-Go System Files after creating the setting?

I did - and it works for me:

BusinessCentralApps/GHP-W1#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants