forked from github/codeql
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathDeadStoreOfLocal.cs
486 lines (433 loc) · 8.74 KB
/
DeadStoreOfLocal.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
using System;
using System.Collections.Generic;
public class DeadStoreOfLocal
{
delegate int D();
int fn(D d) { return d(); }
public int M1()
{
int x = M2(); // $ Alert
return (x = 1) + x; // GOOD
}
public int M2()
{
int x = 1; // GOOD
return x + (x = 1); // $ Alert
}
public int M3()
{
return fn(() =>
{
int y;
y = 1; // GOOD
return y;
});
}
public int M4()
{
return fn(delegate ()
{
int y;
y = 1; // GOOD: Assignment in delegate function
return y;
});
}
public void M5()
{
int x = M3(); // $ Alert
}
public void M6()
{
int x = 42;
x += 1; // $ Alert
}
public void M7()
{
int x = 42;
x++; // $ Alert
}
public IEnumerable<string> M8(IEnumerable<string> source)
{
var count = 0; // GOOD
foreach (var val in source)
{
yield return val;
Console.WriteLine(++count); // GOOD
}
}
public IEnumerable<string> M9(IEnumerable<string> source)
{
var count = 0; // GOOD
foreach (var val in source)
{
count += 1; // GOOD
yield return val;
Console.WriteLine(count);
}
}
public void M10(IEnumerable<string> source)
{
foreach (var val in source) // $ Alert
{
}
}
}
public abstract class ExceptionsFlow
{
public abstract void Process();
public void F()
{
string info1 = "", info2 = "", extra, message = "";
try
{
info1 = "Starting"; // GOOD: Used in exception handler
message = "Unsuccessful completion"; // GOOD: Used in finally
Process();
info2 = "Finishing"; // GOOD: Used in exception handler
extra = "Dead store here"; // $ Alert Dead store
Process();
message = "Successful completion"; // GOOD: Used in finally
info1 = "Used in handler"; // $ Alert Used in handler, but not a reachable handler
}
catch (SystemException ex)
{
throw new Exception("Failure in " + info1, ex);
}
catch (Exception ex)
{
throw new Exception("Failure in " + info2, ex);
}
finally
{
Console.WriteLine(message);
}
}
public void FinallyFlow1()
{
int stage = 0;
try
{
Console.WriteLine("Stage " + stage);
stage = 1; // GOOD: Used in finally
throw new Exception();
}
finally
{
Console.WriteLine("Stage " + stage);
}
}
public void FinallyFlow2()
{
int stage = 0;
try
{
Process();
}
catch (Exception ex) // $ Alert
{
Console.WriteLine("Stage " + stage);
stage = 3; // GOOD: Used in finally
throw;
}
finally
{
Console.WriteLine("Stage " + stage);
}
}
}
public class OutParam
{
public void Test()
{
int x;
Fn(out x); // $ MISSING: Alert
Fn(out _); // GOOD
}
void Fn(out int x)
{
x = 0;
}
}
public class AssignmentArrayAliasing
{
public void Test(double[] x)
{
var y = x; // GOOD: y aliases an array that is accessed below
y[0] %= 2;
}
}
public class Captured
{
delegate int D();
int fn(D d) { return d(); }
void M1()
{
var x = 1; // GOOD
Action a = () =>
{
Console.WriteLine(x);
};
a();
}
void M2()
{
var x = M6(); // $ MISSING: Alert
Action a = () =>
{
x = 1; // GOOD
Console.WriteLine(x);
};
a();
}
void M3()
{
int x;
Action a = () =>
{
x = 1; // $ MISSING: Alert
};
a();
}
void M4()
{
int x;
Action a = () =>
{
x = 1; // GOOD
Action aa = () =>
{
Console.WriteLine(x);
};
aa();
};
a();
}
void M5()
{
int x = 0; // $ MISSING: Alert
Action a = () =>
{
x = 1; // GOOD
};
a();
Console.WriteLine(x);
}
int M6()
{
fn(() =>
{
int y = M6(); // $ Alert
return (y = 1) + y; // GOOD
});
int captured = 0; // GOOD: Variable captured variable
fn(() => { return captured; });
return captured = 1; // $ MISSING: Alert
}
void M7()
{
var y = 12; // GOOD: Not a dead store (used in delegate)
fn(() =>
{
var x = y; // $ Alert Dead store in lambda
return 0;
});
}
Action A;
void M8()
{
var cap = 0; // GOOD
A = () => Console.WriteLine(cap);
M9();
}
void M9()
{
A();
}
void M10(bool b)
{
var x = ""; // GOOD
Action action;
if (b)
action = () => System.Console.WriteLine(x);
else
action = () => { };
action();
}
}
class Patterns
{
void Test()
{
object o = null;
if (o is int i1)
{ // GOOD
Console.WriteLine($"int {i1}");
}
else if (o is var v1) // $ Alert
{
}
switch (o)
{
case "xyz":
break;
case int i2 when i2 > 0: // GOOD
Console.WriteLine($"positive {i2}");
break;
case int i3: // GOOD
Console.WriteLine($"int {i3}");
break;
case var v2: // $ Alert
break;
default:
Console.WriteLine("Something else");
break;
}
}
}
class Tuples
{
void M()
{
(int x, (bool b, string s)) = GetTuple(); // GOOD
Use(x);
Use(b);
Use(s);
(x, (b, s)) = GetTuple(); // $ Alert on `b`
Use(x);
Use(s);
(x, (_, s)) = GetTuple(); // GOOD
Use(x);
Use(s);
}
(int, (bool, string)) GetTuple()
{
return (0, (false, ""));
}
static void Use<T>(T u) { }
}
class Initializers
{
string M1()
{
var s = string.Empty; // "GOOD"
s = "";
return s;
}
string M2()
{
var s = ""; // "GOOD"
s = "";
return s;
}
string M3()
{
string s = null; // "GOOD"
s = "";
return s;
}
string M4()
{
var s = M3(); // $ Alert
s = "";
return s;
}
string M5()
{
var s = default(string); // "GOOD"
s = "";
return s;
}
string M6(bool b)
{
var s = "";
if (b)
s = "abc"; // GOOD
if (b)
return s;
return null;
}
string M7(bool b)
{
var s = "";
if (b)
s = "abc"; // $ Alert
if (!b)
return s;
return null;
}
string M8()
{
string s = default; // "GOOD"
s = "";
return s;
}
string M9()
{
var s = (string)null; // "GOOD"
s = "";
return s;
}
}
class Anonymous
{
int M(bool b)
{
var x = new { a = 0, b = 0 }; // GOOD
if (b)
{
x = new { a = 1, b = 1 };
}
else
{
x = new { a = 2, b = 2 };
}
return x.a + x.b;
}
}
class Finally
{
int M(bool b)
{
int i = 0; // GOOD
try
{
if (b)
throw new Exception();
}
finally
{
i = 1; // GOOD
}
return i;
}
}
public static class AnonymousVariable
{
public static int Count<T>(this IEnumerable<T> items)
{
int count = 0;
foreach (var _ in items) // GOOD
count++;
return count;
}
}
public static class Using
{
public static void M()
{
using var x = new System.IO.FileStream("", System.IO.FileMode.Open); // GOOD
using var _ = new System.IO.FileStream("", System.IO.FileMode.Open); // GOOD
using (var y = new System.IO.FileStream("", System.IO.FileMode.Open)) // $ Alert
{
}
}
}
class StringInterpolation
{
void Pi()
{
float pi = 3.14159f; // GOOD
const int align = 6; // GOOD
Console.WriteLine($"Pi, {pi,align:F3}");
}
}