Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Runes #156

Open
saabi opened this issue Dec 26, 2023 · 7 comments
Open

Migrate to Runes #156

saabi opened this issue Dec 26, 2023 · 7 comments
Assignees
Labels
advisory Notice of something

Comments

@saabi
Copy link

saabi commented Dec 26, 2023

After attempting to port a working Svelte 3/LayerCake app (using npm i -S --force LayerCake) I got the error above (ERR_SVELTE_TOO_MANY_UPDATES).

To verify the bug wasn't on my side, I moved an arbitrary working LayerCake REPL example to the Svelte 5 Preview REPL and I get the same error:

playground:output:801 Uncaught Error: ERR_SVELTE_TOO_MANY_UPDATES: Maximum update depth exceeded. This can happen when a reactive block or effect repeatedly sets a new value. Svelte limits the number of nested updates to prevent infinite loops.
    at infinite_loop_guard (playground:output:801:10)
    at flush_queued_effects (playground:output:818:4)
    at process_microtask (playground:output:845:3)

Working REPL Example: https://svelte.dev/repl/ad32f9f301484d0cace82272126e9d09?version=3.46.2
Svelte 5 REPL Example (failing)

@mhkeller
Copy link
Owner

Thanks for letting me know. I’m waiting for the full Svelte 5 release before figuring out what form LayerCake takes. Given that the library is a collection of stores and stores are no more, it will mean a significant rewrite.

@saabi
Copy link
Author

saabi commented Dec 29, 2023

I may be able to help out with that... I do dataviz, performance and low level for a living. Check out https://github.com/nestauk/svizzle It doesn't use LayerCake (yet) but a port is planned.

It will have to wait for a new LayerCake release however.

@mhkeller
Copy link
Owner

Great – thanks for the offer! The first approach I plan on trying will be to replace every store with a $state rune and then instead of derived stores, use $derived. I haven't seen any examples on how runes interact with contexts, though.

Slots are also deprecated so there will have to be some changes there, too. It looks like the existing syntax may work if layout components render a children snippet.

But since Svelte 5 is still a moving target, I think it's better to wait until it settles.

@mhkeller mhkeller changed the title LayerCake on Svelte 5 fails with ERR_SVELTE_TOO_MANY_UPDATES Update to Svelte 5 Dec 29, 2023
@mhkeller mhkeller added the awaiting-something-else Needs some other thing to happen before it can be done label Feb 10, 2024
@mhkeller mhkeller self-assigned this Feb 10, 2024
@mhkeller mhkeller changed the title Update to Svelte 5 Update to Svelte 5 when it's released Feb 10, 2024
@mhkeller
Copy link
Owner

mhkeller commented May 3, 2024

There's a PR for making this compatible with Svelte 5. I may merge it or may wait until 5.0.0 is out: #190

edit: this has been merged and the library is compatible with Svelte 5

@mhkeller
Copy link
Owner

mhkeller commented May 3, 2024

FYI the existing LayerCake library works out of the box in Svelte 5 projects. That PR clears up some peerDependency warnings.

Eventually I will port LayerCake to using runes but it will require changes to component API. Using $state runes, you can no longer destructure values from contexts like you can with stores

import { getContext } from 'svelte';
const { xGet, yGet } = getContext('LayerCake');

// becomes...

const chart = getContext('LayerCake')
chart.xGet
chart.yGet

I may include a helper so you're not interacting with getContext directly

import { LayerCake, Svg, getChart } from 'layercake';

const c = getChart();

c.xGet
c.YGet

The design is still TBD but that approach seems to help with the ergonomics. Feedback welcome.

@mhkeller mhkeller changed the title Update to Svelte 5 when it's released Migrate to Runes May 9, 2024
@mhkeller
Copy link
Owner

mhkeller commented May 9, 2024

A note on the timing for this: Since the library is compatible with Svelte 4 and 5 but a migration to runes will cut off support for anything less than Svelte 5, I'm not in a huge rush to do that. It may make most sense to wait for something like Svelte 6 when some of the features Layer Cake uses become deprecated.

The goal here being that it works for the largest number of people.

@mhkeller
Copy link
Owner

This PR will update the library to Svelte 5 now that 5.0.0 is released: #242

@mhkeller mhkeller added advisory Notice of something and removed awaiting-something-else Needs some other thing to happen before it can be done labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advisory Notice of something
Projects
None yet
Development

No branches or pull requests

2 participants