Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed login call might break resuming a session #164

Open
bratelefant opened this issue Jan 29, 2025 · 0 comments
Open

Failed login call might break resuming a session #164

bratelefant opened this issue Jan 29, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@bratelefant
Copy link
Collaborator

In User.js, in the _loginWithToken method, right before calling the servers login method, the flag this._isCallingLogin is set. Subsequent calls of _loginWithToken will not execute a login request to the server.

if (this._isCallingLogin) {

Although this helps to prevent sending unnecessary multiple requests, there's a problem in the following situation (observed multiple times in production): If, for some reason, the login request does not finish (connection broken, timeouts, etc), the app remains in the state where this._isCallingLogin === true; hence, any further attempts to resume the user session will fail.

@bratelefant bratelefant added the bug Something isn't working label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant