Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

going to "/verify-captcha" reveals server-side error #27

Open
Streemo opened this issue Nov 18, 2015 · 0 comments
Open

going to "/verify-captcha" reveals server-side error #27

Streemo opened this issue Nov 18, 2015 · 0 comments

Comments

@Streemo
Copy link

Streemo commented Nov 18, 2015

Routing to /verify-captcha reveals the following, which is not OK for production:

TypeError: Cannot call method 'hasOwnProperty' of undefined
    at appendFormValue (/bundle/bundle/programs/server/npm/meteorhacks_sikka/node_modules/request/request.js:463:17)
    at Request.init (/bundle/bundle/programs/server/npm/meteorhacks_sikka/node_modules/request/request.js:477:11)
    at new Request (/bundle/bundle/programs/server/npm/meteorhacks_sikka/node_modules/request/request.js:264:8)
    at request (/bundle/bundle/programs/server/npm/meteorhacks_sikka/node_modules/request/index.js:50:10)
    at Function.request.post (/bundle/bundle/programs/server/npm/meteorhacks_sikka/node_modules/request/index.js:80:27)
    at Object._processCaptcha (packages/meteorhacks_sikka/packages/meteorhacks_sikka.js:361:1)
    at _verifyCaptchaMiddleware (packages/meteorhacks_sikka/packages/meteorhacks_sikka.js:342:1)
    at doCall (packages/meteorhacks_picker/packages/meteorhacks_picker.js:106:1)
    at [object Object].PickerImp._processRoute (packages/meteorhacks_picker/packages/meteorhacks_picker.js:100:1)
    at processNextRoute (packages/meteorhacks_picker/packages/meteorhacks_picker.js:68:1)

Suggested fix:

//in Sikka.routes._processCaptcha middleware

var captchResponse = parsedUrl.query['g-recaptcha-response'];

//add this check to make sure the query param exists
if (!captchResponse){
  return next();
}

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant