From 9f68870884546af297fda9dff7a598adc266bee1 Mon Sep 17 00:00:00 2001 From: Kartik Ohri Date: Mon, 26 Sep 2022 21:00:12 +0530 Subject: [PATCH] fix test - 2 --- critiquebrainz/frontend/forms/review.py | 2 +- critiquebrainz/frontend/views/test/test_review.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/critiquebrainz/frontend/forms/review.py b/critiquebrainz/frontend/forms/review.py index db4235363..19a94a071 100644 --- a/critiquebrainz/frontend/forms/review.py +++ b/critiquebrainz/frontend/forms/review.py @@ -63,7 +63,7 @@ def validate_license_choice(self, field): else: # https://wtforms.readthedocs.io/en/2.3.x/_modules/wtforms/validators/#InputRequired if not field.raw_data or not field.raw_data[0]: - raise ValidationError(lazy_gettext("You need to choose a license")) + raise ValidationError(lazy_gettext("You need to choose a license.")) # choice validation for RadioField's is done in pre_validate in WTForms which executes prior to # this validator. it does not take into consideration whether the review is draft or not so we diff --git a/critiquebrainz/frontend/views/test/test_review.py b/critiquebrainz/frontend/views/test/test_review.py index d431ddf04..f6ecb9f88 100644 --- a/critiquebrainz/frontend/views/test/test_review.py +++ b/critiquebrainz/frontend/views/test/test_review.py @@ -179,7 +179,6 @@ def test_draft_without_license_choice(self): # test publishing draft review without license causes error data["state"] = "publish" - data["rating"] = 4 response = self.client.post( "/review/%s/edit" % review["id"], data=data,