Skip to content

Commit 61fdefa

Browse files
committed
TST: adjust for changes in pyproject-metadata 0.9.0
1 parent 35f2842 commit 61fdefa

File tree

4 files changed

+28
-12
lines changed

4 files changed

+28
-12
lines changed

pyproject.toml

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ dynamic = [
4747
[project.optional-dependencies]
4848
test = [
4949
'build',
50+
'packaging >= 23.1',
5051
'pytest >= 6.0',
5152
'pytest-cov[toml]',
5253
'pytest-mock',

tests/conftest.py

+7
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
from venv import EnvBuilder
1818

19+
import packaging.metadata
1920
import packaging.version
2021
import pytest
2122

@@ -24,6 +25,12 @@
2425
from mesonpy._util import chdir
2526

2627

28+
def metadata(data):
29+
meta, other = packaging.metadata.parse_email(data)
30+
assert not other
31+
return meta
32+
33+
2734
def adjust_packaging_platform_tag(platform: str) -> str:
2835
if platform.startswith(('manylinux', 'musllinux')):
2936
# The packaging module generates overly specific platforms tags on

tests/test_metadata.py

+2
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ def test_missing_version(package_missing_version):
5353
re.escape('Required "project.version" field is missing'),
5454
# pyproject-metatadata 0.8.0 and later
5555
re.escape('Field "project.version" missing and "version" not specified in "project.dynamic"'),
56+
# pyproject-metatadata 0.9.0 and later
57+
re.escape('Field "project.version" missing and \'version\' not specified in "project.dynamic"'),
5658
))
5759
with pytest.raises(pyproject_metadata.ConfigurationError, match=match):
5860
Metadata.from_pyproject(pyproject, pathlib.Path())

tests/test_sdist.py

+18-12
Original file line numberDiff line numberDiff line change
@@ -4,41 +4,42 @@
44

55
import os
66
import pathlib
7-
import re
87
import stat
98
import sys
109
import tarfile
1110
import textwrap
1211
import time
1312

13+
from itertools import chain
14+
1415
import pytest
1516

1617
import mesonpy
1718

18-
from .conftest import in_git_repo_context
19+
from .conftest import in_git_repo_context, metadata
1920

2021

2122
def test_no_pep621(sdist_library):
2223
with tarfile.open(sdist_library, 'r:gz') as sdist:
2324
sdist_pkg_info = sdist.extractfile('library-1.0.0/PKG-INFO').read().decode()
2425

25-
assert sdist_pkg_info == textwrap.dedent('''\
26+
assert metadata(sdist_pkg_info) == metadata(textwrap.dedent('''\
2627
Metadata-Version: 2.1
2728
Name: library
2829
Version: 1.0.0
29-
''')
30+
'''))
3031

3132

3233
def test_pep621(sdist_full_metadata):
3334
with tarfile.open(sdist_full_metadata, 'r:gz') as sdist:
34-
sdist_pkg_info = sdist.extractfile('full_metadata-1.2.3/PKG-INFO').read().decode()
35+
sdist_pkg_info = sdist.extractfile('full_metadata-1.2.3/PKG-INFO').read()
3536

36-
metadata = re.escape(textwrap.dedent('''\
37+
expected = metadata(textwrap.dedent('''\
3738
Metadata-Version: 2.1
3839
Name: full-metadata
3940
Version: 1.2.3
4041
Summary: Some package with all of the PEP 621 metadata
41-
Keywords: full metadata
42+
Keywords: full, metadata
4243
Home-page: https://example.com
4344
Author: Jane Doe
4445
Author-Email: Unknown <[email protected]>
@@ -70,20 +71,25 @@ def test_pep621(sdist_full_metadata):
7071
An example package with all of the PEP 621 metadata!
7172
'''))
7273

73-
# pyproject-metadata 0.8.0 and later uses a comma to separate keywords
74-
expr = metadata.replace(r'Keywords:\ full\ metadata', r'Keywords:\ full[ ,]metadata')
75-
assert re.fullmatch(expr, sdist_pkg_info)
74+
meta = metadata(sdist_pkg_info)
75+
76+
# pyproject-metadata prior to 0.8.0 incorrectly uses whitespace to separate keywords
77+
meta['keywords'] = list(chain(*(k.split(' ') for k in meta['keywords'])))
78+
# pyproject-metadata prior to 0.9.0 strips trailing newlines
79+
meta['license'] = meta['license'].rstrip()
80+
81+
assert meta == expected
7682

7783

7884
def test_dynamic_version(sdist_dynamic_version):
7985
with tarfile.open(sdist_dynamic_version, 'r:gz') as sdist:
8086
sdist_pkg_info = sdist.extractfile('dynamic_version-1.0.0/PKG-INFO').read().decode()
8187

82-
assert sdist_pkg_info == textwrap.dedent('''\
88+
assert metadata(sdist_pkg_info) == metadata(textwrap.dedent('''\
8389
Metadata-Version: 2.1
8490
Name: dynamic-version
8591
Version: 1.0.0
86-
''')
92+
'''))
8793

8894

8995
def test_contents(sdist_library):

0 commit comments

Comments
 (0)