Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batches typing issues #1876

Closed
mdubus opened this issue Feb 27, 2025 · 1 comment · Fixed by #1825
Closed

Batches typing issues #1876

mdubus opened this issue Feb 27, 2025 · 1 comment · Fixed by #1825
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mdubus
Copy link
Member

mdubus commented Feb 27, 2025

Description
When working with batches, I encountered some issues with typing:

  • Batch type is not exported from meilisearch. It has to be imported from meilisearch/src/batch
  • batchUids doesn't exist in the TasksQuery type (but the query with it works perfectly fine, having me think it was forgotten)

Expected behavior
We should be able to import the Batch type from meilisearch directly.
Using the batchUids as a parameter shouldn't throw a typescript error.

Screenshots or Logs

Image
@mdubus mdubus added bug Something isn't working good first issue Good for newcomers labels Feb 27, 2025
@flevi29
Copy link
Collaborator

flevi29 commented Feb 27, 2025

#1825 fixes this issue.

@flevi29 flevi29 linked a pull request Mar 2, 2025 that will close this issue
3 tasks
@flevi29 flevi29 self-assigned this Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants