Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#9820): update @medic/eslint-config and remove duplicate rules #9821

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jkuester
Copy link
Contributor

Description

Closes #9820

We recently updated the @medic/eslint-config repo to include many of the custom rules that we had defined here in cht-core. This PR is to update this repo to depend on the new version of @medic/eslint-config and remove the duplicate rules from our eslint config here.

The catch 😅 is that our config/* projects also depend on @medic/eslint-config , but were not being linted by the root level eslint rules. 😬 So there were a number of changes across these config projects that needed to be made for the linting to pass. Most of these fixes were auto-implemented via eslint --fix.

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@jkuester jkuester requested review from lorerod and removed request for lorerod February 25, 2025 23:24
@jkuester jkuester marked this pull request as draft February 25, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade @medic/eslint-config and clean up duplicate rules
1 participant