Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#9760): add support for sso user create/update (DRAFT) #9800

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rmayore
Copy link

@rmayore rmayore commented Feb 19, 2025

…ng of oidc users

Description

Updates libs/user-management to allow for creating or updating of SSO couch users.

To Do:

  1. Fix Error messages
  2. Figure out how to run the added tests, verify they pass

#9760

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@rmayore
Copy link
Author

rmayore commented Feb 20, 2025

I might have also inadvertently done part of #9763 and #9764

@jkuester
Copy link
Contributor

@rmayore regarding the key value in the errors, it looks like I was correct that it is only used in the admin app. That code is what handles the edit user functionality in the "App Management" tool. It calls the api server to edit the user and if it gets an error back with a key value, it will try to translate that key value and display it to the user.

For our SSO login logic in this PR, I do not think we need to include a key in our errors. It should never be possible in the normal usage of the app for a user to hit any of these SSO errors when creating/updating a user. (E.g. the UI for the admin app should prevent a user from being able to enter a password value for an SSO user...). It should be sufficient to just include a good error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants