Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring headers in outbound push #9799

Open
witash opened this issue Feb 19, 2025 · 3 comments · May be fixed by #9818
Open

Allow configuring headers in outbound push #9799

witash opened this issue Feb 19, 2025 · 3 comments · May be fixed by #9818
Assignees
@witash
Labels
Type: Feature Add something new

Comments

@witash
Copy link
Contributor

witash commented Feb 19, 2025

Outbound push may sometimes require different HTTP headers such as User-Agent; currently its not possible to add or change HTTP headers other than authorization.

Allow headers to be added or changed in configuration like

        "headers": {
          "User-Agent": "CHT-Integration/1.0 libwww/2.17b3"
        },
@witash witash added the Type: Feature Add something new label Feb 19, 2025
@witash witash self-assigned this Feb 19, 2025
@gitcliff
Copy link

Format https://httpwg.org/specs/rfc9110.html#field.user-agent

@mrjones-plip
Copy link
Contributor

@witash - I think not setting a user agent is bug (per the forum that inspired this ticket).

Maybe more tightly scope this ticket to just be:

Add user-agent header to outbound push

I can't see a need for additional headers just yet - do you know of a need?

@gitcliff
Copy link

hello @witash @mrjones-plip any progress on this issue ?

witash added a commit that referenced this issue Feb 24, 2025
@witash
fix(#9799): add user-agent header to outbound
a1e59d4
@witash witash linked a pull request Feb 24, 2025 that will close this issue
Open
witash added a commit that referenced this issue Feb 25, 2025
@witash
chore(#9799): fixining lint
9bb8220
witash added a commit that referenced this issue Feb 27, 2025
@witash
fix(#9799): moving deploy-info to environment
e37c649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@witash witash

Labels
Type: Feature Add something new
Projects
CHT Stewardship Activities Q1
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#9799): add user-agent header to outbound medic/cht-core
3 participants
@witash @mrjones-plip @gitcliff