Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Right to Left languages #9682

Open
mrjones-plip opened this issue Dec 3, 2024 · 7 comments · May be fixed by #9727
Open

Add support for Right to Left languages #9682

mrjones-plip opened this issue Dec 3, 2024 · 7 comments · May be fixed by #9727
Assignees
@dianabarsan
Labels
Type: Technical issue Improve something that users won't notice
Milestone
4.18.0

Comments

@mrjones-plip
Copy link
Contributor

Describe the issue
Currently CHT Core assumes all languages are left to right (English, French, etc.).

Describe the improvement you'd like
Support languages that are right to left (RTL) like Arabic
@mrjones-plip mrjones-plip added the Type: Technical issue Improve something that users won't notice label Dec 3, 2024
@mrjones-plip
Copy link
Contributor Author

Related forum post

@mrjones-plip mrjones-plip mentioned this issue Dec 3, 2024
Closed
@andrablaj
Copy link
Member

@garethbowen I copied your notes from this document to keep track of your first findings publicly.

Glossary

RTL: Right To Left
RHS: Right Hand Side
LHS: Left Hand Side

General text

Google translate was used to check that the character sets are supported, and manually added dir="rtl" to the HTML to test the right alignment.

Image

Navigation

The new "material" navigation coming soon will feature a drawer sliding out from the LHS.

Image

Layout of the large screen app

The app currently shows the list on the LHS and the detail on the RHS.

Image

Form navigation

Buttons are right aligned.

Image

Filters

Filters are on the RHS

Image

Dates

Calendars and dates are in the Gregorian calendar.
Image

@andrablaj
Copy link
Member

Additionally, Arabic translations were merged via #9683 and should be available in 4.16.

@andrablaj
Copy link
Member

Notes after talking with @latin-panda:

  • Ensure RTL works for both old and new designs.
  • If we decide to support RTL only for the new design (> 4.12), ensure the old design is not broken by the RTL implementation.

@dianabarsan dianabarsan self-assigned this Dec 16, 2024
@dianabarsan dianabarsan linked a pull request Jan 6, 2025 that will close this issue
Draft
6 tasks
@andrablaj andrablaj moved this to In Progress in CHT Stewardship Activities Q1 Jan 6, 2025
@dianabarsan
Copy link
Member

I've made some progress on this in a branch: #9727

Image
Image
Image
Image
Image
Image
ImageImage

Calendars and report filters still need updates.

@andrablaj andrablaj added this to the 4.17.0 milestone Jan 28, 2025
@andrablaj
Copy link
Member

I optimistically added this issue to 4.17 Milestone. 😁

@andrablaj andrablaj modified the milestones: 4.17.0, 4.18.0 Feb 4, 2025
@andrablaj
Copy link
Member

Moved this issue to 4.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianabarsan dianabarsan

Labels
Type: Technical issue Improve something that users won't notice
Projects
CHT Stewardship Activities Q1
Status: In Progress
Milestone
4.18.0
Development

Successfully merging a pull request may close this issue.

[DNM] feat(#9682): rtl support medic/cht-core
3 participants
@mrjones-plip @andrablaj @dianabarsan