Skip to content

Typing a . triggers TypeScript completions if Astro extension is installed #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
corneliusroemer opened this issue Jul 10, 2024 · 8 comments · Fixed by #460
Closed
4 tasks done

Typing a . triggers TypeScript completions if Astro extension is installed #457

corneliusroemer opened this issue Jul 10, 2024 · 8 comments · Fixed by #460
Labels
🌊 blocked/upstream This cannot progress before something external happens first 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on

Comments

@corneliusroemer
Copy link

corneliusroemer commented Jul 10, 2024

Initial checklist

Affected packages and versions

v1.8.9

Link to runnable example

No response

Steps to reproduce

  1. Install mdx extension for vscode: https://marketplace.visualstudio.com/items?itemName=unifiedjs.vscode-mdx
  2. Make .mdx file with following content:
---
layout: ../../.././layouts/DocLayout.astro
title: "Getting an authentication token for programmatic access"
order: 2
---

## Need 
  1. Install vimium extension
  2. Enter insert mode in the layout string
  3. Type period .
  4. Type another period .
  5. Observe result

Expected behavior

A literal period is inserted

Actual behavior

Some long string is inserted that I don't want inserted

See Gif:

2024-07-10 17 19 44

Runtime

Other (please specify in steps to reproduce)

Package manager

Other (please specify in steps to reproduce)

OS

macOS

Build and bundle tools

Other (please specify in steps to reproduce)

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 10, 2024
@ChristianMurphy
Copy link
Member

Welcome @corneliusroemer! 👋
Sorry you ran into a spot of trouble.

For triage purposes.

  1. What version of VSCode are you using?
    code --version
  2. What other extensions do you have installed in your VSCode?
    code --list-extensions

When you say vimium are you referring to https://github.com/philc/vimium?
vimium isn't related to vscode or language servers...

Do you mean something else like https://github.com/VSCodeVim/Vim ?

A general sense is this feels like a conflicting keybindings issue similar to #422

@ChristianMurphy ChristianMurphy added the 🙉 open/needs-info This needs some more info label Jul 11, 2024

This comment has been minimized.

@stuartherbert
Copy link

I'm having the exact same problem, only I don't have any sort of Vim plugin installed.

code --version
1.91.1
f1e16e1e6214d7c44d078b1f0607b2388f29d729
arm64
code --list-extensions
absszero.vscode-laravel-goto
akashagarwal.markdown-meaningful-wordcount
alefragnani.bookmarks
alefragnani.project-manager
amiralizadeh9480.laravel-extra-intellisense
arturock.gitstash
astro-build.astro-vscode
austenc.tailwind-docs
bbenoist.vagrant
bmewburn.vscode-intelephense-client
bradlc.vscode-tailwindcss
christian-kohler.npm-intellisense
codezombiech.gitignore
coolbear.systemd-unit-file
davidanson.vscode-markdownlint
dbaeumer.vscode-eslint
donjayamanne.githistory
editorconfig.editorconfig
ericadamski.carbon-now-sh
formulahendry.auto-close-tag
formulahendry.auto-rename-tag
github.vscode-github-actions
github.vscode-pull-request-github
glenn2223.live-sass
golang.go
hbenl.vscode-test-explorer
heybourn.headwind
joelday.docthis
kisstkondoros.vscode-codemetrics
macieklad.tailwind-sass-syntax
mechatroner.rainbow-csv
mhutchie.git-graph
mrmlnc.vscode-apache
ms-azuretools.vscode-docker
ms-dotnettools.vscode-dotnet-runtime
ms-python.debugpy
ms-python.isort
ms-python.python
ms-python.vscode-pylance
ms-toolsai.jupyter
ms-toolsai.jupyter-keymap
ms-toolsai.jupyter-renderers
ms-toolsai.vscode-jupyter-cell-tags
ms-toolsai.vscode-jupyter-slideshow
ms-vscode-remote.remote-containers
ms-vscode-remote.remote-ssh-edit
ms-vscode.hexeditor
ms-vscode.makefile-tools
ms-vscode.test-adapter-converter
ms-vsliveshare.vsliveshare
mystk.vscode-mocha-two
octref.vetur
onecentlin.laravel-blade
qcz.text-power-tools
redhat.vscode-yaml
redocly.openapi-vs-code
rido3.wordcount
ritwickdey.liveserver
robinbentley.sass-indented
ronnidc.nunjucks
tuxtina.json2yaml
ujo.findinfilescontext
undefined_publisher.phix-dark
unifiedjs.vscode-mdx
vue.volar
waderyan.gitblame
whatwedo.twig
xdebug.php-debug
xdebug.php-pack
yzhang.markdown-all-in-one
zignd.html-css-class-completion
ziyasal.vscode-open-in-github

It looks like a problem with Intellisense kicking in when it shouldn't. I've tried disabling Intellisense of MDX, but the problem continues.

@stuartherbert
Copy link

Disabling the Astro plugin stops the problem from happening.

@lrstanley
Copy link

Running into the same exact issue.

$ code --version
1.91.1
f1e16e1e6214d7c44d078b1f0607b2388f29d729
x64
$ code --list-extensions
42crunch.vscode-openapi
a-h.templ
albert.tabout
alefragnani.project-manager
amazonwebservices.aws-toolkit-vscode
antfu.iconify
astro-build.astro-vscode
bradlc.vscode-tailwindcss
davidanson.vscode-markdownlint
dbaeumer.vscode-eslint
eamodio.gitlens
editorconfig.editorconfig
esbenp.prettier-vscode
foxundermoon.shell-format
github.copilot
github.copilot-chat
github.remotehub
github.vscode-pull-request-github
golang.go
graphql.vscode-graphql
graphql.vscode-graphql-execution
graphql.vscode-graphql-syntax
hashicorp.hcl
hashicorp.terraform
heybourn.headwind
james-yu.latex-workshop
jinliming2.vscode-go-template
mitchdenny.ecdc
ms-kubernetes-tools.vscode-kubernetes-tools
ms-playwright.playwright
ms-python.debugpy
ms-python.isort
ms-python.python
ms-toolsai.jupyter
ms-toolsai.jupyter-renderers
ms-toolsai.vscode-jupyter-cell-tags
ms-toolsai.vscode-jupyter-slideshow
ms-vscode.cpptools
ms-vscode.remote-repositories
ms-vsliveshare.vsliveshare
naumovs.color-highlight
redhat.vscode-yaml
richie5um2.vscode-sort-json
signageos.signageos-vscode-sops
steoates.autoimport
supermaven.supermaven
svelte.svelte-vscode
timonwong.shellcheck
tomoki1207.vscode-input-sequence
unifiedjs.vscode-mdx
vscode.docker
vscode.yaml
vue.volar
wakatime.vscode-wakatime
wenfangdu.snippet-generator
yoavbls.pretty-ts-errors
yzhang.markdown-all-in-one
znck.grammarly
zxh404.vscode-proto3
  • Windows 11, WSL 2.0 w/ Ubuntu 20.04.6 LTS
  • astro-build.astro-vscode -- v2.13.1
  • unifiedjs.vscode-mdx -- v1.8.9

Can confirm that disabling Astro does seem to fix the issue. Not sure which side the actual issue is on though.

@remcohaszing remcohaszing changed the title Bug: In vscode, period . inserts something other than a literal period when used with vimium Typing a . triggers TypeScript completions if Astro extension is installed Aug 8, 2024
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on 👍 phase/yes Post is accepted and can be worked on labels Aug 8, 2024
@github-actions github-actions bot removed 🤞 phase/open Post is being triaged manually 🙉 open/needs-info This needs some more info labels Aug 8, 2024

This comment was marked as outdated.

@remcohaszing remcohaszing mentioned this issue Aug 8, 2024
5 tasks
@remcohaszing remcohaszing added 🌊 blocked/upstream This cannot progress before something external happens first 👶 semver/patch This is a backwards-compatible fix labels Aug 8, 2024
@remcohaszing
Copy link
Member

I have reproduced this bug and confirm this is caused by the combination of the Astro and MDX extensions. It will be fixed by #460 once Volar 2.4 is released.

In case anyone is interesting in further reading: I have a hunch about it’s caused by the same internal issue as #451, but I’m not completely sure.

Copy link
Contributor

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 blocked/upstream This cannot progress before something external happens first 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on
Development

Successfully merging a pull request may close this issue.

5 participants