Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unchecked error/panic #31

Closed
wants to merge 1 commit into from
Closed

Fix unchecked error/panic #31

wants to merge 1 commit into from

Conversation

gechr
Copy link

@gechr gechr commented Oct 9, 2020

Fixes #30

This occurs either when caused by client policy (such as CheckRedirect), or failure to speak HTTP (such as a network connectivity problem). A non-2xx status code doesn't cause an error.

Verified

This commit was signed with the committer’s verified signature.
ras0q Kira Kawai
@coveralls
Copy link

coveralls commented Oct 9, 2020

Pull Request Test Coverage Report for Build 69

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 54.065%

Changes Missing Coverage Covered Lines Changed/Added Lines %
network.go 1 3 33.33%
Totals Coverage Status
Change from base Build 66: -0.4%
Covered Lines: 133
Relevant Lines: 246

💛 - Coveralls

@gechr gechr closed this Oct 12, 2020
@gechr gechr deleted the gc-fix-unchecked-err branch October 12, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfault on https endpoints on GKE
2 participants