Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusable with tauri v2 because of serde_json version #143

Open
MarcWadai opened this issue Jan 27, 2025 · 3 comments
Open

Unusable with tauri v2 because of serde_json version #143

MarcWadai opened this issue Jan 27, 2025 · 3 comments

Comments

@MarcWadai
Copy link

In seshat serde_json is set to version strictly equal to "=1.0.61".

Except that in tauri-build v2 we need serde_json to be at least "1.0.95".

Would it be possible to update seshat serde_json version ?

@poljar
Copy link
Collaborator

poljar commented Feb 14, 2025

Sadly that's not easily possible, we would need to bump the Tantivy version as well due to:

seshat/Cargo.toml

Lines 40 to 44 in 395fe7c

# This is pinned because Tantivy used an serde re-export that turned private in
# 1.0.119.
# Relevant serde commit https://github.com/serde-rs/serde/commit/dd1f4b483ee204d58465064f6e5bf5a457543b54
# Tantivy patch that fixes this issue https://github.com/tantivy-search/tantivy/pull/975

Bumping Tantivy on the other hand means that the index on the application side needs to be rebuilt, which requires some UI work.

@MarcWadai
Copy link
Author

MarcWadai commented Feb 19, 2025

Thanks for the answer @poljar . I was able to update :

tantivy: 0.13.3
serde_json = "1.0.95"
serde = { version = "1"}

Without code changes (Needs more testing.)

When you talk about UI changes, what kind of changes are we talking about ? Is it a loader to indicate it is taking more time to search and re-index ? or something else ?

@poljar
Copy link
Collaborator

poljar commented Feb 19, 2025

Yeah, basically Element Desktop needs to have an UI telling you that the index is being regenerated.

Without code changes (Needs more testing.)

Yes, that's true, Tantivy didn't break the API in a meaningful manner, but it did break the index/storage format, from the CHANGELOG:

Tantivy 0.13 introduce a change in the index format that will require you to reindex your index (BlockWAND information are added in the skiplist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants