Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check combineLatest types on reactiveNextOperator #246

Open
appsforartists opened this issue Jul 20, 2018 · 0 comments
Open

Check combineLatest types on reactiveNextOperator #246

appsforartists opened this issue Jul 20, 2018 · 0 comments

Comments

@appsforartists
Copy link
Member

appsforartists commented Jul 20, 2018 •
edited
Loading

reactiveNextOperator injects {upstream: Observable<T>} into combineLatest, which is currently typed to be D (the inputs dictionary). The inputs kwarg shouldn't require upstream. When I tried to use reactiveNextOperator, TypeScript was complaining that I hadn't passed in upstream in inputs.

I just took a quick stab at fixing this in http://codereview.cc/D3451, but I didn't dig in deeply enough to verify they're correct.
appsforartists added a commit that referenced this issue Jul 20, 2018
@appsforartists
[added] upstream to _reactiveNextOperator's combineLatest generic
61ad597 
Summary: This is a quick fix that should be thought through more thoroughly in #246.

Reviewers: O2 Material Motion, O3 Material JavaScript platform reviewers, #material_motion

Tags: #material_motion

Differential Revision: http://codereview.cc/D3451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@appsforartists