Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Manufacturers show up twice for Several Manufacturers #2608

Open
Sugarsmacks opened this issue Feb 24, 2025 · 1 comment
Open

[BUG] Manufacturers show up twice for Several Manufacturers #2608

Sugarsmacks opened this issue Feb 24, 2025 · 1 comment

Comments

@Sugarsmacks
Copy link

Describe the bug
When adding licenses to a character, it lists the name twice for certain manufacturers headings (eg. Grimm & Sons Grimm & Sons) and this causes the names on the left in the license to be extended below each section, and makes it almost impossible to select them as options. Especially bad with Waffenfabrik Zalewski.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Pilot'
  2. Click on 'Tactical Profile'
  3. Click on 'Edit Licenses'
  4. Scroll down to 'Waffenfabrik Zalewski'
  5. See error 'Extends beyond edge of license box, cannot select the desired license

Expected behavior
Able to select and view licenses like all the other manufacturers

Screenshots

Image

Image

Image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome and Firefox, happens on both
  • Version 136.0b9

Additional context
Add any other context about the problem here.

@msprijatelj
Copy link
Contributor

This is partially because the SVGs linked to the manufacturer are not setup with proper CORS. However, it’s valid that perhaps CompCon should gracefully handle these improperly configured icons.

That said, here are steps from Shotch on the Pilot NET Discord on how the brewers can fix it on their end:

INFO:
Manufacturer icons should be a pure black svg with no outline, the colorationg and border is added automatically in Comp/Con
The expected display units are in px, and the size of the corebook icons are 1080x1080 with a scale factor of 1, and a stroke with of 1px
These steps should be followed to get it ready for importing into your lcp.

  1. Run your exported SVG through https://www.svgminify.com/ either by putting in an existing link to one, or uploading it directly.
    a. Click Start once your file is in
    b. Copy the text in the box, you do not need to actually Download resulting SVG.

  2. Make a new gist at https://gist.github.com/ with the svg content copied from the prior step.
    Note: you'll need a github account for this step, create one if you do not have one
    a. In the field Filename including extension give it a name, but it must end with .svg as the file extension.
    b. Paste the copied text from the prior step.
    c. Search for any stroke="#XXXXXX" or fill="#XXXXXX" tags in the data and delete them - starting from < to > for the whole tag
    d. Click Create secret gist

  3. After creating the gist, you should be on a page displaying the SVG.
    a. Right click the image, Copy Image Link

  4. Put the link in the lcp.
    If using the editor:
    Put the url you just copied in the Logo Url field for the selected manufacturer under the Manufacturers & Licenses section

If manually writing lcps:
put the url you just copied in the "logo_url" field in your manufacturers.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants