Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag var hoisting #2534

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Tag var hoisting #2534

wants to merge 3 commits into from

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Feb 25, 2025

Description

  • Hoist native tag references
  • Hoist custom tag variables
  • Hoist dynamic tag variables

Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: ce4a89b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 88.14353% with 76 lines in your changes missing coverage. Please review.

Project coverage is 87.03%. Comparing base (b898aa0) to head (3a5bf8c).

Files with missing lines Patch % Lines
...ime-tags/src/translator/visitors/tag/native-tag.ts 90.69% 20 Missing ⚠️
...ime-tags/src/translator/visitors/tag/custom-tag.ts 50.00% 19 Missing ⚠️
packages/runtime-tags/src/html/serializer.ts 85.96% 16 Missing ⚠️
packages/runtime-tags/src/dom/control-flow.ts 72.41% 8 Missing ⚠️
packages/runtime-tags/src/html/writer.ts 77.77% 4 Missing ⚠️
...ges/runtime-tags/src/translator/util/references.ts 84.00% 4 Missing ⚠️
packages/runtime-tags/src/dom/walker.ts 66.66% 3 Missing ⚠️
...ackages/compiler/src/babel-types/traverse/patch.js 0.00% 1 Missing ⚠️
packages/runtime-tags/src/dom/renderer.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
- Coverage   87.04%   87.03%   -0.01%     
==========================================
  Files         351      351              
  Lines       40399    40923     +524     
  Branches     2693     2756      +63     
==========================================
+ Hits        35165    35619     +454     
- Misses       5207     5277      +70     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rturnq rturnq force-pushed the tag-var-hoisting branch 2 times, most recently from 3a5bf8c to 37df135 Compare February 25, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant