-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
false negative for screenshot #981
Comments
Hey @williballenthin , Thanks! |
i'd recommend trying to reproduce the issue, running capa against the sample and confirming the rule does not match. then you can use the show-features.py script to see the available features and figure out the changes needed to the existing rule. thank you! |
Update_1 : Hello @williballenthin, As per your instructions, I tried reproducing the issue. I ran capa against two executables—one using CreateDC and another using GDI+ routines for screenshot capture. In both cases, capa did not detect ATT&CK Technique T1113 (Screen Capture), confirming that the issue is valid and needs to be addressed. CreateDC output 👇 GDI+ Output👇 Below are the executables I used along with their capa results. Let me know if you’d like me to take any additional steps. Create DC GDI+ Thanks! — Abhyuday |
Update_2: Hello @williballenthin, I spent the Sunday exploring capa-rules and YAML. Based on my understanding, I implemented a few changes in the collection/screenshot/screenshot-capture.yml , adding new rules to address the issue mentioned above, along with a few other gaps in capa’s screenshot detection mechanism. I've attached the draft_rule below. Please let me know if you have any suggestions or improvements. Thanks! draft_rule : Google Drive Link |
Update_3: Hey @williballenthin , I’ve made the necessary changes for screenshot detection. The below version detects screenshot capture that uses GDI+ routines as well as CreateDC with other arguments along with DISPLAY. The test files include two executables that demonstrate the improved detection. Here are my commits: Could you review and let me know if everything looks good before I submit the PR? |
would you please open a PR so we can comment inline and discuss there? |
Hello @williballenthin , I've opened the PR for the screenshot detection rule test files: Let me know if any changes are needed! Thanks! |
maybe we need to:
Originally posted by @williballenthin in mandiant/capa#2532 (comment)
The text was updated successfully, but these errors were encountered: