You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Under certain circumstances cyclePause might become negative and then the check ! cyclePause considers it not being paused.
In my use case, I am pausing the cycle plugin (cycle("pause")), when a video is being played in the slider.
This interferes with the pause option to pause/resume on mouseenter/mouseleave. This is why I bind the same events on all child elements, and stop propagation of the event to the upper cycle container:
I am proposing a fix for this (also mentioned in issue #44).
I am not sure, if cyclePause needs to be something else than 0/1 to make the "pause on hover" work properly. If so, this should get documented in the code and another fix needs to be made for this.
The text was updated successfully, but these errors were encountered:
blueyed
added a commit
to blueyed/cycle
that referenced
this issue
Sep 4, 2013
I just noticed that my patch will cause the plugin to resume on mouseenter/-leave, if "pause on hover" is being used, after the "pause" action has been called manually.
In this case mouseenter/-leave should not resume it.
Under certain circumstances
cyclePause
might become negative and then the check! cyclePause
considers it not being paused.In my use case, I am pausing the cycle plugin (
cycle("pause")
), when a video is being played in the slider.This interferes with the
pause
option to pause/resume on mouseenter/mouseleave. This is why I bind the same events on all child elements, and stop propagation of the event to the upper cycle container:I am proposing a fix for this (also mentioned in issue #44).
I am not sure, if
cyclePause
needs to be something else than 0/1 to make the "pause on hover" work properly. If so, this should get documented in the code and another fix needs to be made for this.The text was updated successfully, but these errors were encountered: