Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete shipping carrier creates exception in shipping tracking pop-up #39549

Open
1 of 5 tasks
andirosu opened this issue Jan 17, 2025 · 2 comments
Open
1 of 5 tasks
Assignees
Labels
Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.

Comments

@andirosu
Copy link

Preconditions and environment

On Magento 2.4.7-p3, you can create a shipping carrier model that says it has tracking, but the getTrackingInfo() call is not enforced for implementation.

Steps to reproduce

  1. Create order as a customer with a shipping carrier that has isTrackingAvailable() = true , but doesn't have any declaration of getTrackingInfo (eg: https://commercemarketplace.adobe.com/sameday-magento2-plugin.html)
  2. Invoice and ship the order (use any random number as tracking code).
  3. Navigate as customer to the customer sales over view and open the "track this shipment" pop-up

Expected result

Pop-up opens with some tracking info.

Actual result

The pop-up opens with this message:
"An error has happened during application run. See exception log for details."

Additional information

In the exception log, the Call to undefined method Magento\\Framework\\Phrase::getTracking() message is added.
In the [details.phtml]
file (

$number = is_object($track) ? $track->getTracking() : $track['number'];
)

The template's block returns a Phrase object if the carrier doesn't have tracking info, causing the wrong call:

$trackingInfo = $carrierInstance->getTrackingInfo($this->getNumber()); if (!$trackingInfo) { return __('No detail for number "%1"', $this->getNumber()); }
This can be caused because the CarrierInterface doesn't force carriers to implement the getTrackingInfo method and therefore, carriers can be created with
public function isTrackingAvailable() { return true; }
but no getTrackingInfo function defined.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jan 17, 2025

Hi @andirosu. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo self-assigned this Jan 17, 2025
Copy link

m2-assistant bot commented Jan 17, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p3 Indicates original Magento version for the Issue report. label Jan 17, 2025
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.
Projects
Status: Ready for Confirmation
Development

No branches or pull requests

2 participants