You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On Magento 2.4.7-p3, you can create a shipping carrier model that says it has tracking, but the getTrackingInfo() call is not enforced for implementation.
The template's block returns a Phrase object if the carrier doesn't have tracking info, causing the wrong call:
$trackingInfo = $carrierInstance->getTrackingInfo($this->getNumber()); if (!$trackingInfo) { return __('No detail for number "%1"', $this->getNumber()); }
This can be caused because the CarrierInterface doesn't force carriers to implement the getTrackingInfo method and therefore, carriers can be created with public function isTrackingAvailable() { return true; }
but no getTrackingInfo function defined.
Release note
No response
Triage and priority
Severity: S0- Affects critical data or functionality and leaves users without workaround.
Severity: S1- Affects critical data or functionality and forces users to employ a workaround.
Severity: S2- Affects non-critical data or functionality and forces users to employ a workaround.
Severity: S3- Affects non-critical data or functionality and does not force users to employ a workaround.
Severity: S4- Affects aesthetics, professional look and feel, “quality” or “usability”.
The text was updated successfully, but these errors were encountered:
Hi @andirosu. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel. ⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
4. Verify that the issue is reproducible on 2.4-develop branchDetails- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x. - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.
Preconditions and environment
On Magento 2.4.7-p3, you can create a shipping carrier model that says it has tracking, but the getTrackingInfo() call is not enforced for implementation.
Steps to reproduce
Expected result
Pop-up opens with some tracking info.
Actual result
The pop-up opens with this message:
"An error has happened during application run. See exception log for details."
Additional information
In the exception log, the
Call to undefined method Magento\\Framework\\Phrase::getTracking()
message is added.In the [details.phtml]
file (
magento2/app/code/Magento/Shipping/view/frontend/templates/tracking/details.phtml
Line 21 in 971142b
The template's block returns a Phrase object if the carrier doesn't have tracking info, causing the wrong call:
$trackingInfo = $carrierInstance->getTrackingInfo($this->getNumber()); if (!$trackingInfo) { return __('No detail for number "%1"', $this->getNumber()); }
This can be caused because the CarrierInterface doesn't force carriers to implement the
getTrackingInfo
method and therefore, carriers can be created withpublic function isTrackingAvailable() { return true; }
but no getTrackingInfo function defined.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: