Configurable products marked out of stock incorrectly #3350

aligent-lturner · 2022-05-18T07:08:13Z

Preconditions (*)

Non-default inventory source and stock has been set up
Configurable product set up with one or more simple products
Simple products are all out of stock at default source
At least one simple product in stock (with plenty of stock) at other sources

Steps to reproduce (*)

Create and ship an order with a configurable product using a source other than the default source.
Wait for stock reindexing and check the salable status of the configurable product

Expected result (*)

Configurable product remains salable, as simple products are still salable at non-default sources

Actual result (*)

Configurable product is marked as not salable

Additional information

I believe this is caused by https://github.com/magento/inventory/blob/e08a47c3501de2cbff42b3ac05058ce15d620e75/InventoryConfigurableProduct/Plugin/InventoryApi/UpdateParentStockStatusInLegacyStockPlugin.php

This plugin updates the status of configurable products based on the stock status of their simple components, but it does not take the inventory setup into account at all. In our case, the default source has not been updated at all, yet the result is that the cataloginventory_stock_item table is updated for the configurable product. As a result of this, the inventory stock indexer takes this changed value into account and subsequently marks the configurable as not salable for any non-default stocks.

There is an additional plugin https://github.com/magento/inventory/blob/e08a47c3501de2cbff42b3ac05058ce15d620e75/InventoryConfigurableProduct/Plugin/InventoryApi/UpdateConfigurableProductParentStockStatus.php that was added later that appears to be for much the same purpose, but with additional checks that single source mode and a single store are being used.

The text was updated successfully, but these errors were encountered:

m2-assistant · 2022-05-18T07:08:15Z

Hi @aligent-lturner. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

IvanVizcaino · 2022-05-18T13:51:37Z

I have the same problem. Any temporal solution available? Thanks

maheshm-kensium · 2022-06-01T11:26:43Z

HI @aligent-lturner ,

We are also facing similar issue, when we installed either 2.4.4 CE/EE the MSI modules will be installed as part Magento Core application through composer and enabled by default.

When MSI modules are enabled the configurable parent product stock status are not updating correctly and always stays in Out Of Stock (OOS) once the stock status changed from Is In stock to OOS (either by updating child product stock status or parent).

If we disable MSI Inventory modules then configurable parent product stock status updating as expected.

I already reported this below, so please refer for information.
magento/magento2#35494 (comment)
magento/magento2#35494 (comment)

Expecting, someone going to address this ASAP as it is Major bug for all vendors. Please let me know if anyone needs additional information.

IvanVizcaino · 2022-06-01T11:49:03Z

Hello, I have a temporal solution that is working for me. We are override \Magento\ConfigurableProduct\Model\Inventory\ChangeParentStockStatus The problem is the variable $childrenIsInStock is initialized a false and then never change the value. We are calculated the value of this variable with the sum of sources quantities. This is incorrect if you use stock for websites, but this is a fastest solution for us to resolve the problem in production environment. This is my function processStockForParent


private function processStockForParent(int $productId): void
    {
        $criteria = $this->criteriaInterfaceFactory->create();
        $criteria->setScopeFilter($this->stockConfiguration->getDefaultScopeId());

        $criteria->setProductsFilter($productId);
        $stockItemCollection = $this->stockItemRepository->getList($criteria);
        $allItems = $stockItemCollection->getItems();
        if (empty($allItems)) {
            return;
        }
        $parentStockItem = array_shift($allItems);

        $childrenIds = $this->configurableType->getChildrenIds($productId);
        $criteria->setProductsFilter($childrenIds);
        $stockItemCollection = $this->stockItemRepository->getList($criteria);
        $allItems = $stockItemCollection->getItems();

        $childrenIsInStock = false;
        $childs = array();
        if(isset($childrenIds[0])){
            $childs = $this->productCollection->addAttributeToSelect('sku')
                ->addFieldToFilter('entity_id', array('in' => $childrenIds[0]));
        }
       
        foreach ($childs as $childItem) {
            $salableQty = $this->getSalableQuantityDataBySku->execute($childItem->getSku());
            $qty = 0;
            foreach($salableQty as $source){
                $qty += $source['qty'];
            }

            if ($qty > 0) {
                $childrenIsInStock = true;
                break;
            }
        }


        if ($this->isNeedToUpdateParent($parentStockItem, $childrenIsInStock)) {
            $parentStockItem->setIsInStock($childrenIsInStock);
            $parentStockItem->setStockStatusChangedAuto(1);
            $this->stockItemRepository->save($parentStockItem);
        }
    }

alvinnguyen · 2022-06-16T10:38:53Z

Is this related to https://support.magento.com/hc/en-us/articles/4428085214093-MDVA-42584-Stock-status-of-configurable-product-not-updated-automatically? It might not be as the patch mentioned the issues is via simple product being updated via API or import.

maheshm-kensium · 2022-09-06T07:39:14Z

Hi, has anyone looking in to this issue?

danielrussob · 2022-09-14T10:59:40Z

solved in quality patch: MDVA-41061-V4 and ACSD-45488

https://devdocs.magento.com/quality-patches/tool.html#patch-grid

Playhf · 2022-10-05T09:58:21Z

ACSD-45488

Seems like it wasn't solved. Still experiencing an issue with it. Configurable goes OOS

indunie · 2022-10-18T17:05:56Z

Experienced the same. Below patches didn't solve the issue. Any recent update?
MDVA-41061-V4 and ACSD-45488

sohelrana09 · 2022-10-20T09:37:14Z

After shipment, the configurable product goes OOS just because of https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ConfigurableProduct/Model/Inventory/ChangeParentStockStatus.php#L100. 2.4.4 introduced with https://github.com/magento/inventory/blob/e08a47c3501de2cbff42b3ac05058ce15d620e75/InventoryConfigurableProduct/Plugin/InventoryApi/UpdateParentStockStatusInLegacyStockPlugin.php. When you have more than one source, cataloginventory_stock_item table stock status never update and your entire things will broken. Made adjustment with MSI like @IvanVizcaino did.

cuongho803 · 2022-11-08T02:08:59Z

Hello there, I am facing this issue too, now I think the problem stays in this file "
"vendor/magento/module-inventory-configurable-product-indexer/Indexer/SelectBuilder.php".
`$select = $connection->select()
->from(
['stock' => $indexTableName],
[
IndexStructure::SKU => 'parent_product_entity.sku',
IndexStructure::QUANTITY => 'SUM(stock.quantity)',
IndexStructure::IS_SALABLE => 'IF(inventory_stock_item.is_in_stock = 0, 0, MAX(stock.is_salable))',
]
)->joinInner(
['product_entity' => $this->resourceConnection->getTableName('catalog_product_entity')],
'product_entity.sku = stock.sku',
[]
)->joinInner(
['parent_link' => $this->resourceConnection->getTableName('catalog_product_super_link')],
'parent_link.product_id = product_entity.entity_id',
[]
)->joinInner(
['parent_product_entity' => $this->resourceConnection->getTableName('catalog_product_entity')],
'parent_product_entity.' . $linkField . ' = parent_link.parent_id',
[]
)->joinLeft(
['inventory_stock_item' => $this->resourceConnection->getTableName('cataloginventory_stock_item')],
'inventory_stock_item.product_id = parent_product_entity.entity_id'
. ' AND inventory_stock_item.stock_id = ' . $this->defaultStockProvider->getId(),
[]
)
->group(['parent_product_entity.sku']);

    return $select;`

The IndexStructure::IS_SALABLE => 'IF(inventory_stock_item.is_in_stock = 0, 0, MAX(stock.is_salable))' condition seem wrong if the stock leagagy for configurable =0 therefore the is_salable for "inventory_stock_x" table wrong too. Can we change to "IndexStructure::IS_SALABLE => 'IF(MAX(stock.is_salable),MAX(stock.is_salable),inventory_stock_item.is_in_stock)'," instead ?

kwilliams-concentrix · 2022-11-28T22:06:57Z

Any update here? We are experiencing in 2.4.5p-1 still

RonanCapitaine · 2022-12-06T14:27:43Z

Hello,

I got the same issue on my side. I temporary created this patch :
AC_FIX_INVENTORY_CONFIGURABLE_STOCK_2.4.5.patch.txt

kamilszewczyk · 2022-12-08T15:43:53Z

Hello,

I got the same issue on my side. I temporary created this patch : AC_FIX_INVENTORY_CONFIGURABLE_STOCK_2.4.5.patch.txt

That patch seems to be working perfectly on 2.4.4 as well. Thanks!

Stuart-1 · 2023-01-10T12:01:52Z

This issue also exists for bundled products

barryvdh · 2023-01-23T14:43:38Z

And grouped products..

…x related to magento/inventory#3350 magento/magento2#35724

dverkade · 2023-03-13T10:04:00Z

@RonanCapitaine are you able to raise a PR with your changes so that Magento / Adobe can review this and merge it in for the next release? That would help us all! Really appreciate your efforts.

indrisepos · 2023-03-30T19:40:19Z

I got the same issue on my side. I temporary created this patch : AC_FIX_INVENTORY_CONFIGURABLE_STOCK_2.4.5.patch.txt

It works fine with Magento 2.4.5-p2! Thank you very much! I note that ACSD-45488 unfortunately did not fix it.

vbuiendertech · 2024-04-25T08:04:50Z

Hello,

I got the same issue on my side. I temporary created this patch : AC_FIX_INVENTORY_CONFIGURABLE_STOCK_2.4.5.patch.txt

Hi Ronan,

I have the same issue on the Magento 2.4.6-p5.

But this patch can't apply on the M2.4.6-p5 because this file doesn't exist on this Magento version.

Please let me know if you have any solution for the last Magento version.

Thanks

portchris · 2024-06-27T13:01:42Z

For those still experiencing issues where configurable products stock status fails to update when child products come back in-stock.
I've created a patch which works for my Magento 2.4.6-p1 instance suffering from this virus...

--- a/vendor/magento/module-configurable-product/Model/Inventory/ChangeParentStockStatus.php	2024-06-27 11:54:34.515474442 +0100
+++ b/vendor/magento/module-configurable-product/Model/Inventory/ChangeParentStockStatus.php	2024-06-27 11:56:33.263253341 +0100
@@ -1,8 +1,10 @@
 <?php
+
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 declare(strict_types=1);

 namespace Magento\ConfigurableProduct\Model\Inventory;
@@ -83,27 +85,38 @@

         $criteria->setProductsFilter($productId);
         $stockItemCollection = $this->stockItemRepository->getList($criteria);
+
+        /** @var \Magento\CatalogInventory\Model\Stock\Item[] */
         $allItems = $stockItemCollection->getItems();
         if (empty($allItems)) {
+
             return;
         }
+
         $parentStockItem = array_shift($allItems);

         $childrenIds = $this->configurableType->getChildrenIds($productId);
+        $childrenIds = (is_array($childrenIds) && !empty($childrenIds) && is_array($childrenIds[0]))
+            ? $childrenIds[0]
+            : $childrenIds;
+
         $criteria->setProductsFilter($childrenIds);
         $stockItemCollection = $this->stockItemRepository->getList($criteria);
-        $allItems = $stockItemCollection->getItems();

+        /** @var \Magento\CatalogInventory\Model\Stock\Item[] */
+        $allItems = $stockItemCollection->getItems();
         $childrenIsInStock = false;
-
         foreach ($allItems as $childItem) {
+
             if ($childItem->getIsInStock() === true) {
+
                 $childrenIsInStock = true;
                 break;
             }
         }

         if ($this->isNeedToUpdateParent($parentStockItem, $childrenIsInStock)) {
+
             $parentStockItem->setIsInStock($childrenIsInStock);
             $parentStockItem->setStockStatusChangedAuto(1);
             $parentStockItem->setStockStatusChangedAutomaticallyFlag(true);
@@ -122,7 +135,7 @@
         StockItemInterface $parentStockItem,
         bool $childrenIsInStock
     ): bool {
-        return $parentStockItem->getIsInStock() !== $childrenIsInStock &&
-            ($childrenIsInStock === false || $parentStockItem->getStockStatusChangedAuto());
+
+        return $parentStockItem->getIsInStock() !== $childrenIsInStock;
     }
 }

serzhik · 2024-10-20T11:52:56Z

Patch ACSD-48910 fixed this issue for me. It works for Magento 2.4.5-x. (https://experienceleague.adobe.com/en/docs/commerce-knowledge-base/kb/support-tools/patches/v1-1-42/acsd-48910-bundle-product-assigned-to-multiple-sources-out-of-stock)

nordcomputer · 2025-02-27T11:57:13Z

For those still experiencing issues where configurable products stock status fails to update when child products come back in-stock. I've created a patch which works for my Magento 2.4.6-p1 instance suffering from this virus...

--- a/vendor/magento/module-configurable-product/Model/Inventory/ChangeParentStockStatus.php 2024-06-27 11:54:34.515474442 +0100
+++ b/vendor/magento/module-configurable-product/Model/Inventory/ChangeParentStockStatus.php 2024-06-27 11:56:33.263253341 +0100
@@ -1,8 +1,10 @@
setProductsFilter($productId); $stockItemCollection = $this->stockItemRepository->getList($criteria); + + /** @var \Magento\CatalogInventory\Model\Stock\Item[] */ $allItems = $stockItemCollection->getItems(); if (empty($allItems)) { + return; } + $parentStockItem = array_shift($allItems); $childrenIds = $this->configurableType->getChildrenIds($productId); + $childrenIds = (is_array($childrenIds) && !empty($childrenIds) && is_array($childrenIds[0])) + ? $childrenIds[0] + : $childrenIds; + $criteria->setProductsFilter($childrenIds); $stockItemCollection = $this->stockItemRepository->getList($criteria); - $allItems = $stockItemCollection->getItems(); + /** @var \Magento\CatalogInventory\Model\Stock\Item[] */ + $allItems = $stockItemCollection->getItems(); $childrenIsInStock = false; - foreach ($allItems as $childItem) { + if ($childItem->getIsInStock() === true) { + $childrenIsInStock = true; break; } } if ($this->isNeedToUpdateParent($parentStockItem, $childrenIsInStock)) { + $parentStockItem->setIsInStock($childrenIsInStock); $parentStockItem->setStockStatusChangedAuto(1); $parentStockItem->setStockStatusChangedAutomaticallyFlag(true); @@ -122,7 +135,7 @@ StockItemInterface $parentStockItem, bool $childrenIsInStock ): bool { - return $parentStockItem->getIsInStock() !== $childrenIsInStock && - ($childrenIsInStock === false || $parentStockItem->getStockStatusChangedAuto()); + + return $parentStockItem->getIsInStock() !== $childrenIsInStock; } }

This also seems to work on 2.4.7-p3

m2-community-project bot added the Progress: ready for grooming label May 18, 2022

szymonnosal mentioned this issue Sep 7, 2022

Configurable product is out of stock after place order AmpersandHQ/magento2-disable-stock-reservation#79

Open

andrewdaluz mentioned this issue Jan 30, 2023

2.4.4 Configurable products are out of stock magento/magento2#35724

Closed

5 tasks

softcommerceltd added a commit to softcommerceltd/magento-inventory-configurable-product that referenced this issue Feb 2, 2023

- **Feature**: New module to handle inventory configurable product fi…

b31a4f9

…x related to magento/inventory#3350 magento/magento2#35724

pixel-paul mentioned this issue Jul 20, 2023

Configurable products marked out of stock - Magento 2.4.4 #3358

Closed

davirs mentioned this issue Apr 2, 2024

INVENTORY BUG. Products not appearing at frontend magento/magento2#38570

Closed

5 tasks

serzhik mentioned this issue Oct 18, 2024

Configurable product goes to out of stock after the shipment is created for one child product magento/magento2#37364

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configurable products marked out of stock incorrectly #3350

Configurable products marked out of stock incorrectly #3350

aligent-lturner commented May 18, 2022

m2-assistant bot commented May 18, 2022

IvanVizcaino commented May 18, 2022

maheshm-kensium commented Jun 1, 2022

IvanVizcaino commented Jun 1, 2022 •

edited

Loading

alvinnguyen commented Jun 16, 2022 •

edited

Loading

maheshm-kensium commented Sep 6, 2022

danielrussob commented Sep 14, 2022

Playhf commented Oct 5, 2022

indunie commented Oct 18, 2022 •

edited

Loading

sohelrana09 commented Oct 20, 2022

cuongho803 commented Nov 8, 2022 •

edited

Loading

kwilliams-concentrix commented Nov 28, 2022

RonanCapitaine commented Dec 6, 2022

kamilszewczyk commented Dec 8, 2022

Stuart-1 commented Jan 10, 2023

barryvdh commented Jan 23, 2023

dverkade commented Mar 13, 2023

indrisepos commented Mar 30, 2023

vbuiendertech commented Apr 25, 2024

portchris commented Jun 27, 2024

serzhik commented Oct 20, 2024 •

edited

Loading

nordcomputer commented Feb 27, 2025

Configurable products marked out of stock incorrectly #3350

Configurable products marked out of stock incorrectly #3350

Comments

aligent-lturner commented May 18, 2022

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

Additional information

m2-assistant bot commented May 18, 2022

IvanVizcaino commented May 18, 2022

maheshm-kensium commented Jun 1, 2022

IvanVizcaino commented Jun 1, 2022 • edited Loading

alvinnguyen commented Jun 16, 2022 • edited Loading

maheshm-kensium commented Sep 6, 2022

danielrussob commented Sep 14, 2022

Playhf commented Oct 5, 2022

indunie commented Oct 18, 2022 • edited Loading

sohelrana09 commented Oct 20, 2022

cuongho803 commented Nov 8, 2022 • edited Loading

kwilliams-concentrix commented Nov 28, 2022

RonanCapitaine commented Dec 6, 2022

kamilszewczyk commented Dec 8, 2022

Stuart-1 commented Jan 10, 2023

barryvdh commented Jan 23, 2023

dverkade commented Mar 13, 2023

indrisepos commented Mar 30, 2023

vbuiendertech commented Apr 25, 2024

portchris commented Jun 27, 2024

serzhik commented Oct 20, 2024 • edited Loading

nordcomputer commented Feb 27, 2025

IvanVizcaino commented Jun 1, 2022 •

edited

Loading

alvinnguyen commented Jun 16, 2022 •

edited

Loading

indunie commented Oct 18, 2022 •

edited

Loading

cuongho803 commented Nov 8, 2022 •

edited

Loading

serzhik commented Oct 20, 2024 •

edited

Loading