Skip to content

Commit bfc3935

Browse files
cortinicofacebook-github-bot
authored andcommitted
Do not specify a Kotlin version in the RN rootProject (facebook#33589)
Summary: As we introduced KGP inside `ReactAndroid` (cc ShikaSD), we now need to specify a version for it (as users will consume that build on Android New Architecture. Currently, the version is loaded in the RN `rootProject` which is not available on user's project. I'm cleaning this up. ## Changelog [Internal] - Do not specify a Kotlin version in the RN rootProject Pull Request resolved: facebook#33589 Test Plan: Tested on a nightly version with ``` npx react-native init RNNightly --version nightly ``` Reviewed By: mdvacca Differential Revision: D35476777 Pulled By: cortinico fbshipit-source-id: 5a819ef5fa9a6886d7b7b683f31d59cb05a49f29
1 parent 3693928 commit bfc3935

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

ReactAndroid/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
plugins {
99
id("com.android.library")
1010
id("com.facebook.react")
11-
id("org.jetbrains.kotlin.android")
11+
id("org.jetbrains.kotlin.android") version "1.6.10"
1212
id("maven-publish")
1313
id("de.undercouch.download")
1414
}

build.gradle.kts

-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@ buildscript {
1414
mavenCentral()
1515
}
1616
dependencies {
17-
val kotlin_version: String by project
1817
classpath("com.android.tools.build:gradle:7.1.1")
1918
classpath("de.undercouch:gradle-download-task:5.0.1")
20-
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version")
2119
// NOTE: Do not place your application dependencies here; they belong
2220
// in the individual module build.gradle files
2321
}

gradle.properties

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ org.gradle.jvmargs=-Xmx4g -XX:MaxMetaspaceSize=1g -Dfile.encoding=UTF-8
55
org.gradle.parallel=true
66

77
android.useAndroidX=true
8-
kotlin_version=1.6.10
98

109
# Use this property to specify which architecture you want to build.
1110
# You can also override it from the CLI using

0 commit comments

Comments
 (0)