Skip to content

Commit 6836bf3

Browse files
committed
Workaround comma locale issues
1 parent d5df483 commit 6836bf3

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

Editor/BoxClipOriginEditor.cs

+10-5
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2323

2424
[CustomEditor(typeof(BoxClipOrigin))]
2525
// [CanEditMultipleObjects]
26-
public class BoxClipOriginditor : Editor
26+
public class BoxClipOriginEditor : Editor
2727
{
2828
SerializedProperty managedMaterials;
2929
SerializedProperty knownBuiltinMaterials;
@@ -546,8 +546,13 @@ int findAndConsumeComments(string target, int lastPos, string shaderSource) {
546546
return targetPos;
547547
}
548548

549+
static System.Globalization.NumberFormatInfo nfi = new System.Globalization.NumberFormatInfo();
550+
static BoxClipOriginEditor() {
551+
nfi.NumberDecimalSeparator = ".";
552+
}
553+
549554
string printFloat(float f) {
550-
return (float.IsInfinity(f) || float.IsNaN(f)) ? "0" : f.ToString();
555+
return (float.IsInfinity(f) || float.IsNaN(f)) ? "0" : f.ToString(nfi);
551556
}
552557
string printFloat3(Vector4 data) {
553558
return "float3(" + printFloat(data.x) + "," + printFloat(data.y) + "," + printFloat(data.z) + ")";
@@ -588,9 +593,9 @@ Shader BakeShader(Shader orig) {
588593
string outSource = shaderSource.Substring(0, firstQuote) + "\"" + "Hidden/BoxClipBaked/" + AssetDatabase.AssetPathToGUID(generatedDir.stringValue) + "Inst/" + orig.name.Substring(8) + "\" {\n";
589594
outSource += "CGINCLUDE\n" +
590595
" #define BOXCLIP_CONFIGURED 1\n" +
591-
" #define BOXCLIP_SCALE " + scale.floatValue + "\n" +
592-
" #define BOXCLIP_ALLOW_IN_FRONT " + allowInFront.floatValue + "\n" +
593-
" #define BOXCLIP_ALLOW_IN_FRONT " + allowInFront.floatValue + "\n\n";
596+
" #define BOXCLIP_SCALE " + printFloat(scale.floatValue) + "\n" +
597+
" #define BOXCLIP_ALLOW_IN_FRONT " + printFloat(allowInFront.floatValue) + "\n" +
598+
" #define BOXCLIP_ALLOW_IN_FRONT " + printFloat(allowInFront.floatValue) + "\n\n";
594599
outSource += generateBoxQuadsMacro(boxClipObj, "ClipShow", BoxClipOrigin.BoxClipArray.ClipShow);
595600
outSource += generateBoxQuadsMacro(boxClipObj, "ClipHide", BoxClipOrigin.BoxClipArray.ClipHide);
596601
outSource += generateBoxQuadsMacro(boxClipObj, "ShowVolume", BoxClipOrigin.BoxClipArray.ShowVolume);

README.md

+3
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ Tried it? Having trouble? Please say hello to Lyuma#0781 or [email protected] -
3232

3333
## Update notes
3434

35+
### v0.3.3:
36+
- Workaround issues in locales which use commas.
37+
3538
### v0.3.1 and v0.3.2:
3639
- Performance fixes related to geometry culling.
3740

0 commit comments

Comments
 (0)