Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Preset theme options English name is partially hidden due to excessive length #2183

Closed
2 tasks done
3gf8jv4dv opened this issue Dec 17, 2024 · 3 comments · Fixed by #2189
Closed
2 tasks done

Comments

@3gf8jv4dv
Copy link
Contributor

解决方案检查

预期行为

It is hoped that a more aesthetically pleasing way of showing their English names fully without requiring the user to mouse over the item to view it.

实际行为

A portion of the item name is shown as an ellipsis.

Lx Music 版本

2.10.0-beta.9

最后正常的版本

No response

操作系统版本

Windows 11, version 24H2

附加信息

lx-music-desktop-theme-item-name

@lyswhut
Copy link
Owner

lyswhut commented Dec 17, 2024

What suggestions do you have?

@3gf8jv4dv
Copy link
Contributor Author

3gf8jv4dv commented Dec 18, 2024

How does this look?

.themeItem width 56px100px in ThemeSelectorModal.vue & SettingBasic.vue

EDIT: and remove .mixin-ellipsis-1; in SettingBasic.vue.themeItem.label

Preview

lx-music-desktop-theme-selector-1-1
lx-music-desktop-theme-selector-1-2
lx-music-desktop-theme-selector-2-1
lx-music-desktop-theme-selector-2-2

@lyswhut
Copy link
Owner

lyswhut commented Dec 18, 2024

"100px" spacing is too large.
I'd be inclined to remove .mixin-ellipsis-1;

@lyswhut lyswhut linked a pull request Dec 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants