Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reveal password in error message upon connection issue #161

Open
krisavi opened this issue Feb 3, 2022 · 1 comment
Open

Do not reveal password in error message upon connection issue #161

krisavi opened this issue Feb 3, 2022 · 1 comment

Comments

@krisavi
Copy link

krisavi commented Feb 3, 2022

Would be nice if the password is not shown in the error message if there is issues connecting to zabbix.

For me the API is used to build json output for external contact to monitor as guest and when there was issue with connecting to Zabbix, it screamed it into the output that ended up revealing zabbix password to public. I did change the password, so it is all good on that end, but would be nice if it does not print out plaintext password or access token upon connection error in the future. I do not think it is information that helps with debugging issues, it would be ok if the password or access token is replaced with "*".

@szuro
Copy link
Collaborator

szuro commented Feb 9, 2022

Can you provide a code sample for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants