Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Filter reset when clicking on PR #363

Open
SindiBuklaji opened this issue Feb 11, 2025 · 1 comment
Open

[Bug]: Filter reset when clicking on PR #363

SindiBuklaji opened this issue Feb 11, 2025 · 1 comment
Labels
bug Something isn't working inbox Issue comes from a user

Comments

@SindiBuklaji
Copy link

SindiBuklaji commented Feb 11, 2025

Contact Details

[email protected]

What happened?

When you add a filter to the PR list, and then afterwards open a PR, and go back, the list of PRs is no longer containing the filter.
For consistency reasonsI think it makes sense that the filter is still active even when going back to the list.

Steps To Reproduce

  1. Add a filter to the PR list
  2. Click on a PR
  3. Go back to the list of PRs
  4. Notice that the filter is no longer set

Image

What browsers are you seeing the problem on?

Microsoft Edge

Relevant log output

@SindiBuklaji SindiBuklaji added bug Something isn't working inbox Issue comes from a user labels Feb 11, 2025
@egekocabas
Copy link
Member

Thanks @SindiBuklaji for this bug ticket 💯

I think we don't persist the selection, inside the client side we have couple of places that we use localStorage, maybe its better to create a service to generalise the usage, we will work on it 👍🏻

@thielpa thielpa added feature bug Something isn't working inbox Issue comes from a user and removed bug Something isn't working inbox Issue comes from a user feature labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inbox Issue comes from a user
Projects
None yet
Development

No branches or pull requests

3 participants