feat: UI Refactoring #359
Draft
feat: UI Refactoring #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thielpa
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Thank you for this PR, great work reworking the sidebar and the other visual improvements. IMO the expansion of the sidebar is especially great work! I got some comments about this pr though that we should address before merging to production or tackle in following up PRs to this one:
- Check with prof what email adress we should use as contact adress in the about page
- Check with prof if its correct, that we add him as responsible person for content in the imprint page (just to be sure that he knows)
- Some links are outdated in the privacy page. I guess this is a general issue also with Artemis that we should bring up with @krusche.
- If we go for the static images in the about page (see issue below), please be sure you include them in the git large file storage instead.
- Something seems to be off with this link button. Also if you look closely then you see that the repository title is not vertically centered:
| Transport Security, Forward Secrecy, Same Site Cookie protection) to protect the privacy of Helios users in the best possible way. Helios processes personal data in the context | ||
| of teaching and in the context of examinations in compliance with the applicable data protection regulations. The legal basis for the processing of data is Art. 6(1) lit. c | ||
| (Legal Obligation) of the General Data Protection Regulation (GDPR). In addition, Art. 61 of | ||
| <a href="https://www.gesetze-bayern.de/Content/Document/BayHSchG" target="_blank" class="text-blue-500 hover:underline">Bayerisches Hochschulgesetz (BayHschG)</a> as well as |
There was a problem hiding this comment.
This law was replaced by Bayrisches Hochschulinnovationsgesetz and therfor this link does not exist anymore
| <p> | ||
| The purpose of the processing is to fulfill the public duties assigned to us by the legislator, in particular teaching and examination in the university environment. Unless | ||
| otherwise stated, the legal basis for processing your data results from Art. 6(1) lit. c (Legal Obligation) of the General Data Protection Regulation (GDPR). In addition, | ||
| Art. 61 of <a href="https://www.gesetze-bayern.de/Content/Document/BayHSchG" target="_blank" class="text-blue-500">Bayerisches Hochschulgesetz (BayHschG)</a> (BayHschG) as |
There was a problem hiding this comment.
This link does not exist as well
| D-85748 Garching near Munich<br /> | ||
| Telephone: +49(0)-89-289-18018<br /> | ||
| Email: rbg(at)<a href="https://in.tum.de" class="text-blue-500">in.tum.de</a> <br /> | ||
| <a href="https://www.rbg.tum.de" class="text-blue-500">https://www.rbg.tum.de</a> |
There was a problem hiding this comment.
This link does not exist as well
| <h3 class="text-lg font-semibold mt-4">Technical implementation</h3> | ||
| <p> | ||
| The web servers of Helios are operated by the | ||
| <a href="https://www.rbg.tum.de" class="text-blue-500">Rechnerbetriebsgruppe (RBG)</a> of the Technical University of Munich. The personal data you provide when visiting our |
There was a problem hiding this comment.
This link does not work as well
| D-85748 Garching near Munich<br /> | ||
| Telephone: +49-(0)89)-289-18018<br /> | ||
| Email: rbg(at)<a href="https://in.tum.de" class="text-blue-500">in.tum.de</a> <br /> | ||
| <a href="https://rbg.tum.de" class="text-blue-500">https://rbg.tum.de</a> |
client/src/app/components/profile-nav-section/profile-nav-section.component.html
Show resolved
Hide resolved
# Conflicts: # client/src/app/pages/branch-details/branch-details.component.html # client/src/app/pages/branch-details/branch-details.component.ts
|
Thanks @thielpa for your patience of reviewing this huge PR 😅 💯 I have made updates about your comments. For the new pages we have; I have asked our concerns & questions to helios slack channel, I will convert this PR to draft again until we got a response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR includes various client-side fixes and refactoring. Let's review it on Tuesday.
Description
assetsand removedpublicfolder./repo/listMainLayoutComponent, which now detects repository context dynamically.app-navigation-barto control button visibility.about,privacy, andimprintpages.Screenshots
Screen.Recording.2025-02-10.at.20.10.42.mov