Skip to content

Commit 481cee6

Browse files
Hakim Filaliandreaskurth
Hakim Filali
authored andcommitted
[entropy_src/doc] Document the fw_ov_rd_data read when empty behavior
Signed-off-by: Hakim Filali <[email protected]>
1 parent e4f76b4 commit 481cee6

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

hw/ip/entropy_src/data/entropy_src.hjson

+2-1
Original file line numberDiff line numberDiff line change
@@ -1368,7 +1368,7 @@
13681368
fields: [
13691369
{ bits: "0",
13701370
name: "FW_OV_WR_FIFO_FULL",
1371-
desc: '''"When this bit is clear, writes to the FW_OV_WR_DATA register are allowed.
1371+
desc: '''When this bit is clear, writes to the FW_OV_WR_DATA register are allowed.
13721372
If this bit is set, it is the equivalent to a FIFO full condition, and writes
13731373
to the FW_OV_WR_DATA register must be delayed until this bit is reset.
13741374
'''
@@ -1405,6 +1405,7 @@
14051405
A read of this register pops and returns the top of the observe FIFO.
14061406
For this to work, the !!FW_OV_CONTROL.FW_OV_MODE field needs to be set to `kMultiBitBool4True`
14071407
In addition, the otp_en_entropy_src_fw_over input needs to be set to `kMultiBitBool8True`.
1408+
Reading this register while the observe FIFO is empty results in a fatal error with !!ERR_CODE.FIFO_READ_ERR and !!ERR_CODE.SFIFO_OBSERVE_ERR going high.
14081409
'''
14091410
}
14101411
]

hw/ip/entropy_src/doc/registers.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -1193,10 +1193,10 @@ Firmware override FIFO write full status register
11931193
{"reg": [{"name": "FW_OV_WR_FIFO_FULL", "bits": 1, "attr": ["ro"], "rotate": -90}, {"bits": 31}], "config": {"lanes": 1, "fontsize": 10, "vspace": 200}}
11941194
```
11951195

1196-
| Bits | Type | Reset | Name | Description |
1197-
|:------:|:------:|:-------:|:-------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
1198-
| 31:1 | | | | Reserved |
1199-
| 0 | ro | x | FW_OV_WR_FIFO_FULL | "When this bit is clear, writes to the FW_OV_WR_DATA register are allowed. If this bit is set, it is the equivalent to a FIFO full condition, and writes to the FW_OV_WR_DATA register must be delayed until this bit is reset. |
1196+
| Bits | Type | Reset | Name | Description |
1197+
|:------:|:------:|:-------:|:-------------------|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
1198+
| 31:1 | | | | Reserved |
1199+
| 0 | ro | x | FW_OV_WR_FIFO_FULL | When this bit is clear, writes to the FW_OV_WR_DATA register are allowed. If this bit is set, it is the equivalent to a FIFO full condition, and writes to the FW_OV_WR_DATA register must be delayed until this bit is reset. |
12001200

12011201
## FW_OV_RD_FIFO_OVERFLOW
12021202
Firmware override observe FIFO overflow status
@@ -1242,6 +1242,7 @@ Firmware override observe FIFO read register
12421242
A read of this register pops and returns the top of the observe FIFO.
12431243
For this to work, the [`FW_OV_CONTROL.FW_OV_MODE`](#fw_ov_control) field needs to be set to `kMultiBitBool4True`
12441244
In addition, the otp_en_entropy_src_fw_over input needs to be set to `kMultiBitBool8True`.
1245+
Reading this register while the observe FIFO is empty results in a fatal error with [`ERR_CODE.FIFO_READ_ERR`](#err_code) and [`ERR_CODE.SFIFO_OBSERVE_ERR`](#err_code) going high.
12451246

12461247
## FW_OV_WR_DATA
12471248
Firmware override FIFO write register

0 commit comments

Comments
 (0)