Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Adding a message to hint users to clean up non-existing disks in Backing Image CR #10617

Open
PhanLe1010 opened this issue Mar 21, 2025 · 0 comments
Labels
area/backing-image Backing image related area/troubleshoot Troubleshoot related kind/improvement Request for improvement of existing function priority/1 Highly recommended to implement or fix in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone

Comments

@PhanLe1010
Copy link
Contributor

PhanLe1010 commented Mar 21, 2025

Is your improvement request related to a feature? Please describe (👍 if you like this request)

Sometime backing image CR in this cluster are referring non-existing disks which might never come back. Looks like these disks are orphan. I don't see we have logic to clean up these disk in BackingImage CR.
2025-02-24T01:38:35.833470677Z time="2025-02-24T01:38:35Z" level=warning msg="Disk is not ready hence backing image manager can not be created" func="controller.(*BackingImageController).handleBackingImageManagers" file="backing_image_controller.go:738" backingImageName=default-image-vqk8h controller=longhorn-backing-image diskUUID=f5fdea54-a6de-4cd5-9627-29de0a515c0d error="cannot find the corresponding ready node and disk with disk UUID f5fdea54-a6de-4cd5-9627-29de0a515c0d" node=oml-harvester-18

Describe the solution you'd like

Idea from @ChanYiLin

I think the reason is that we dont know if the disk/node is gone forever or not
If we clean up the disk from the bi spec
Then when the disk/node is back, longhorn will delete the file on the disk/node
We can probably add a warning message to let user decide if they want to delete that disk from the spec
They can delete the disk from the spec by click “clean up” in the backing image page in the “operation” for each disk

Describe alternatives you've considered

No response

Additional context

No response

@PhanLe1010 PhanLe1010 added kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated labels Mar 21, 2025
@github-project-automation github-project-automation bot moved this to New Issues in Longhorn Sprint Mar 21, 2025
@PhanLe1010 PhanLe1010 changed the title [IMPROVEMENT] Allow user to clean up non-existing disks in Backing Image Manager CR [IMPROVEMENT] Allow user to clean up non-existing disks in Backing Image CR Mar 21, 2025
@PhanLe1010 PhanLe1010 changed the title [IMPROVEMENT] Allow user to clean up non-existing disks in Backing Image CR [IMPROVEMENT] Adding a message to hint users to clean up non-existing disks in Backing Image CR Mar 21, 2025
@derekbit derekbit added this to the v1.10.0 milestone Mar 21, 2025
@derekbit derekbit added priority/1 Highly recommended to implement or fix in this release (managed by PO) area/backing-image Backing image related area/troubleshoot Troubleshoot related require/manual-test-plan Require adding/updating manual test cases if they can't be automated and removed require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated labels Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backing-image Backing image related area/troubleshoot Troubleshoot related kind/improvement Request for improvement of existing function priority/1 Highly recommended to implement or fix in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
Status: New Issues
Development

No branches or pull requests

2 participants