Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common/trigger_io] g_sync_edge should be externable controllable #2

Open
lerwys opened this issue Nov 29, 2017 · 0 comments
Open

[common/trigger_io] g_sync_edge should be externable controllable #2

lerwys opened this issue Nov 29, 2017 · 0 comments

Comments

@lerwys
Copy link
Contributor

lerwys commented Nov 29, 2017

Problem: There are use cases in which we may want to set the synchronizing RX edge of a pulse via an external pin.

Solution: Change the input sync module to one that allows setting the sync_edge by an external driving pin

lerwys added a commit that referenced this issue Feb 3, 2021
For AXIS, we must assert the PLD_LAST signal on the
last word for a transaction before issuing a new command
on the CMD interface. The condition to detect the last
word has 2 possibilities:

1) Specified number of words written to the DDR3 controller,
typical case in "immediate"" acquisition, and this worked fine.

2) DDR3 AXIS address going over the limit and wrapping back
to the start address. This was always asserting the last word
detection (ddr_eop signal) on the first word of the next
transaction, causing the last word to be written past
the DDR3 end address and the next word to be written
correctly at the DDR start address.

The fix for the case #2 was a simple "=", as we need to consider
the case for the DDR end address to be aligned with the
"ddr_addr_cnt_axis + c_addr_ddr_inc_axis", which is the
condition to the counter to be the last one on the next word.

This was reported by Scott Cogan, from FRIB. Thanks Scott.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant