Reason for cleanKey bad_chars?

[mtmcgrew]

What's the reasoning behind each character in the bad_chars list in cleanKey?

laikaboss/laikaboss/objectmodel.py

Line 47 in dc0dbbf

bad_chars = ['\0', '.', '$']

It translates things like SHELL32.dll into SHELL32_dll

[marnao]

Good question-- thanks for raising this.

tl;dr: bad design

A certain NoSQL database does not allow "." (and a few other characters) to be in the key name. This cleanup should really be done on output (just prior to inserting into the database) rather than in the core framework.

We would be open to a pull request that removes this and any other unnecessary cleanup. Ideally I think we would only have the following 2 restrictions: serializes to JSON and contains only valid UTF-8